From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964914AbXBLNqI (ORCPT ); Mon, 12 Feb 2007 08:46:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964919AbXBLNqI (ORCPT ); Mon, 12 Feb 2007 08:46:08 -0500 Received: from ns2.suse.de ([195.135.220.15]:40957 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964914AbXBLNqF (ORCPT ); Mon, 12 Feb 2007 08:46:05 -0500 Date: Mon, 12 Feb 2007 14:45:54 +0100 Message-ID: From: Takashi Iwai To: Wouter Paesen Cc: Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices In-Reply-To: <20070209165211.GB15805@tougher.kangaroot.net> References: <20070209165211.GB15805@tougher.kangaroot.net> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 9 Feb 2007 17:52:11 +0100, Wouter Paesen wrote: > > > The ca0106 driver does not install a reference to the pci > device in it's __devinit function. This will result in a > missing "device" attribute on the sound devices associated with > this card, which makes hal/libhal ignore the card. > > Signed-off-by: Wouter Paesen Thanks, it's already fixed in the latest git tree. Takashi > -- > > --- linux-2.6.20/sound/pci/ca0106/ca0106_main.c.orig 2007-02-04 19:44:54.000000000 +0100 > +++ linux-2.6.20/sound/pci/ca0106/ca0106_main.c 2007-02-09 17:20:37.000000000 +0100 > @@ -1455,6 +1455,8 @@ static int __devinit snd_ca0106_create(i > snd_ca0106_free(chip); > return err; > } > + > + snd_card_set_dev(card, &pci->dev); > *rchip = chip; > return 0; > } > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >