LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* REGRESSION: Renesas USB host broken after commit d143825baf15
@ 2021-07-20 23:06 Takashi Iwai
  2021-07-20 23:29 ` Moritz Fischer
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2021-07-20 23:06 UTC (permalink / raw)
  To: Moritz Fischer; +Cc: Vinod Koul, Greg Kroah-Hartman, linux-usb, linux-kernel

Hi,

the recent patch landed in 5.13.2 stable tree from the upstream commit
d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
seems causing a regression on a few machines, as reported on openSUSE
Bugzilla:
  https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
  https://bugzilla.opensuse.org/show_bug.cgi?id=1188515

Reverting it on top of 5.13.3 fixed the problem, so it's likely the
cause.  Could you guys take a look?


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: REGRESSION: Renesas USB host broken after commit d143825baf15
  2021-07-20 23:06 REGRESSION: Renesas USB host broken after commit d143825baf15 Takashi Iwai
@ 2021-07-20 23:29 ` Moritz Fischer
  2021-07-21  7:20   ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Moritz Fischer @ 2021-07-20 23:29 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Moritz Fischer, Vinod Koul, Greg Kroah-Hartman, linux-usb, linux-kernel

Hi Takashi,

On Wed, Jul 21, 2021 at 01:06:29AM +0200, Takashi Iwai wrote:
> Hi,
> 
> the recent patch landed in 5.13.2 stable tree from the upstream commit
> d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
> seems causing a regression on a few machines, as reported on openSUSE
> Bugzilla:
>   https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
>   https://bugzilla.opensuse.org/show_bug.cgi?id=1188515
> 
> Reverting it on top of 5.13.3 fixed the problem, so it's likely the
> cause.  Could you guys take a look?

I've sent out a revert patch.

https://lore.kernel.org/linux-usb/20210719070519.41114-1-mdf@kernel.org/T/#u

I think the driver has more problems but I'll tackle that in a follow up
patch, lets get this unbricked, first.

Sorry for the inconvenience,

Moritz

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: REGRESSION: Renesas USB host broken after commit d143825baf15
  2021-07-20 23:29 ` Moritz Fischer
@ 2021-07-21  7:20   ` Takashi Iwai
  2021-07-21  7:54     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2021-07-21  7:20 UTC (permalink / raw)
  To: Moritz Fischer
  Cc: Takashi Iwai, Moritz Fischer, Vinod Koul, Greg Kroah-Hartman,
	linux-usb, linux-kernel

On Wed, 21 Jul 2021 01:29:22 +0200,
Moritz Fischer wrote:
> 
> Hi Takashi,
> 
> On Wed, Jul 21, 2021 at 01:06:29AM +0200, Takashi Iwai wrote:
> > Hi,
> > 
> > the recent patch landed in 5.13.2 stable tree from the upstream commit
> > d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
> > seems causing a regression on a few machines, as reported on openSUSE
> > Bugzilla:
> >   https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
> >   https://bugzilla.opensuse.org/show_bug.cgi?id=1188515
> > 
> > Reverting it on top of 5.13.3 fixed the problem, so it's likely the
> > cause.  Could you guys take a look?
> 
> I've sent out a revert patch.
> 
> https://lore.kernel.org/linux-usb/20210719070519.41114-1-mdf@kernel.org/T/#u
> 
> I think the driver has more problems but I'll tackle that in a follow up
> patch, lets get this unbricked, first.

OK, thank you for the information!


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: REGRESSION: Renesas USB host broken after commit d143825baf15
  2021-07-21  7:20   ` Takashi Iwai
@ 2021-07-21  7:54     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-07-21  7:54 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Moritz Fischer, Moritz Fischer, Vinod Koul, linux-usb, linux-kernel

On Wed, Jul 21, 2021 at 09:20:38AM +0200, Takashi Iwai wrote:
> On Wed, 21 Jul 2021 01:29:22 +0200,
> Moritz Fischer wrote:
> > 
> > Hi Takashi,
> > 
> > On Wed, Jul 21, 2021 at 01:06:29AM +0200, Takashi Iwai wrote:
> > > Hi,
> > > 
> > > the recent patch landed in 5.13.2 stable tree from the upstream commit
> > > d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
> > > seems causing a regression on a few machines, as reported on openSUSE
> > > Bugzilla:
> > >   https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
> > >   https://bugzilla.opensuse.org/show_bug.cgi?id=1188515
> > > 
> > > Reverting it on top of 5.13.3 fixed the problem, so it's likely the
> > > cause.  Could you guys take a look?
> > 
> > I've sent out a revert patch.
> > 
> > https://lore.kernel.org/linux-usb/20210719070519.41114-1-mdf@kernel.org/T/#u
> > 
> > I think the driver has more problems but I'll tackle that in a follow up
> > patch, lets get this unbricked, first.
> 
> OK, thank you for the information!

I've reverted this now, will get it to Linus for 5.14-rc3, sorry about
that.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-21  7:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 23:06 REGRESSION: Renesas USB host broken after commit d143825baf15 Takashi Iwai
2021-07-20 23:29 ` Moritz Fischer
2021-07-21  7:20   ` Takashi Iwai
2021-07-21  7:54     ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).