LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Harald Dunkel <harald.dunkel@t-online.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.24-rc7, intel audio: alsa doesn't say a beep
Date: Sun, 13 Jan 2008 12:26:12 +0100 [thread overview]
Message-ID: <s5h7iie2ch7.wl%tiwai@suse.de> (raw)
In-Reply-To: <47888B41.70803@t-online.de>
At Sat, 12 Jan 2008 10:41:21 +0100,
Harald Dunkel wrote:
>
> Takashi Iwai wrote:
> > At Thu, 10 Jan 2008 23:02:53 +0100,
> > Harald Dunkel wrote:
> >> Takashi Iwai wrote:
> >>> Hm... Just to be sure, try the patch below. It's a clean up patch
> >>> that I'd like to apply later.
> >>>
> >> Sorry, no sound.
> >
> > OK, but I'd like to know whether this makes no regression to rc6.
> > Could you check?
> >
> > Also, what exactly did you test? "No sound" means that no sound from
> > the headphone / line-out or from the speaker?
> >
> > One interesting test would be to increase the value of udelay() in the
> > reverted patch. What happens if it's set to 500?
> >
>
> There is no udelay() in the reverted patch.
Hm? Ingo's patch replaces msleep(1) with udelay(10) +
cond_resched(). This is the patch we're arguing. This was already
reverted (based on your report) on git.
> If I replace "udelay(10)"
> by "udelay(500)" in the original rc7, then there is still no sound.
Interesting... What about udelay(1000)? Then it'll be closer to
msleep(1).
> This is like fishing in the dark. We've got a working version. Why not
> keep it?
Yes, we are shooting in the dark now indeed. Honestly, I have no
concrete idea why the patch breaks the sound initialization.
It seems that Dell machines (or STAC codecs) have problems with the
initialization timing. I don't think that all commands but only
certain some command sequences that are so sensitive to the access
timing. We need to identify this.
Ingo's patch is basically a really nice fix. It reduces the
unnecessary delay, especially improves resume speed much. I'd love to
have it. And above all, I need to understand what is the real
problem. Unfortunately, I have no this hardware and the precise h/w
data, so must rely on testers and a guess work.
thanks,
Takashi
next prev parent reply other threads:[~2008-01-13 11:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 19:53 Harald Dunkel
2008-01-08 7:24 ` Takashi Iwai
2008-01-08 10:10 ` Ingo Molnar
2008-01-08 17:01 ` Harald Dunkel
2008-01-08 17:43 ` Takashi Iwai
2008-01-09 6:03 ` Harald Dunkel
2008-01-09 7:31 ` Takashi Iwai
2008-01-09 20:10 ` Harald Dunkel
2008-01-10 13:30 ` Takashi Iwai
2008-01-10 22:02 ` Harald Dunkel
2008-01-11 6:49 ` Takashi Iwai
2008-01-11 21:55 ` Harald Dunkel
2008-01-13 11:17 ` Takashi Iwai
2008-01-14 20:46 ` Harald Dunkel
2008-01-15 10:07 ` Takashi Iwai
2008-01-12 9:41 ` Harald Dunkel
2008-01-12 17:11 ` Daniel Hazelton
2008-01-14 11:04 ` Takashi Iwai
2008-01-14 21:03 ` Daniel Hazelton
2008-01-15 10:08 ` Takashi Iwai
2008-01-15 19:00 ` Daniel Hazelton
2008-01-13 11:26 ` Takashi Iwai [this message]
2008-01-16 6:53 ` Harald Dunkel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7iie2ch7.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=harald.dunkel@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: 2.6.24-rc7, intel audio: alsa doesn'\''t say a beep' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).