From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB326C4320A for ; Thu, 26 Aug 2021 11:55:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FC1B600D4 for ; Thu, 26 Aug 2021 11:55:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242346AbhHZL4n (ORCPT ); Thu, 26 Aug 2021 07:56:43 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:39586 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242100AbhHZL4m (ORCPT ); Thu, 26 Aug 2021 07:56:42 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 7540D2019C; Thu, 26 Aug 2021 11:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629978954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QHZKyxXzpNyyh6F11roqPilYvKHVBMHNSsDRsPwRuTw=; b=VdPi2sHx2INRci3Wgisahf/8srgXZ5VfoVRzY8mtfRG8E6Fm8tY9aT1AyQkn3oTolhFeW2 blJd59pLErVuEM6IeBjXJRecEqyMGkDqf9Ikcz/MNAzEp9THc3oWTRkkQ27R8wGf4g0lb1 Mw2ZMfj7T4s640JF+iqtkZQKnijdlz4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629978954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QHZKyxXzpNyyh6F11roqPilYvKHVBMHNSsDRsPwRuTw=; b=ORdREBQz/ru1rI2YVAt9eSncHmCqypQkcrcPiC8Vy2vYbx1g3rl0D0Ic3S3Ssezu3mlcyt 9KPJ98h00QCmXLBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 66CD1A3B8B; Thu, 26 Aug 2021 11:55:54 +0000 (UTC) Date: Thu, 26 Aug 2021 13:55:54 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: Mathias Nyman , Moritz Fischer , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: renesas-xhci: Prefer firmware loading on unknown ROM state In-Reply-To: References: <20210819113427.1166-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Aug 2021 13:50:13 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 19, 2021 at 01:34:27PM +0200, Takashi Iwai wrote: > > The recent attempt to handle an unknown ROM state in the commit > > d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state") > > resulted in a regression and reverted later by the commit 44cf53602f5a > > ("Revert "usb: renesas-xhci: Fix handling of unknown ROM state""). > > The problem of the former fix was that it treated the failure of > > firmware loading as a fatal error. Since the firmware files aren't > > included in the standard linux-firmware tree, most users don't have > > them, hence they got the non-working system after that. The revert > > fixed the regression, but also it didn't make the firmware loading > > triggered even on the devices that do need it. So we need still a fix > > for them. > > > > This is another attempt to handle the unknown ROM state. Like the > > previous fix, this also tries to load the firmware when ROM shows > > unknown state. In this patch, however, the failure of a firmware > > loading (such as a missing firmware file) isn't handled as a fatal > > error any longer when ROM has been already detected, but it falls back > > to the ROM mode like before. The error is returned only when no ROM > > is detected and the firmware loading failed. > > > > Along with it, for simplifying the code flow, the detection and the > > check of ROM is factored out from renesas_fw_check_running() and done > > in the caller side, renesas_xhci_check_request_fw(). It avoids the > > redundant ROM checks. > > > > The patch was tested on Lenovo Thinkpad T14 gen (BIOS 1.34). Also it > > was confirmed that no regression is seen on another Thinkpad T14 > > machine that has worked without the patch, too. > > > > Fixes: 44cf53602f5a ("Revert "usb: renesas-xhci: Fix handling of unknown ROM state"") > > BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1189207 > > Signed-off-by: Takashi Iwai > > --- > > drivers/usb/host/xhci-pci-renesas.c | 35 +++++++++++++++++++---------- > > 1 file changed, 23 insertions(+), 12 deletions(-) > > This does not apply to my usb-linus branch, are you sure it is still > needed in Linus's tree right now? I guess we can postpone for 5.15. The patch was written for the code on linux-next, and I see there have been a few code clean up there. But the patch itself could be applied to Linus tree with a slight fuzz, so the stable backport should be fine. If it's still not cleanly applicable, let me know. I'll refresh the patch for whatever preferred branch. thanks, Takashi