LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/8] sound: emuproc.c fix signedness warning
@ 2008-02-28 19:11 Harvey Harrison
  2008-02-29 11:05 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-28 19:11 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: LKML

Reading regs from the fpga into an int instead of a u32, trivial
fix.
sound/pci/emu10k1/emuproc.c:422:34: warning: incorrect type in argument 3 (different signedness)
sound/pci/emu10k1/emuproc.c:422:34:    expected unsigned int [usertype] *value
sound/pci/emu10k1/emuproc.c:422:34:    got int *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 sound/pci/emu10k1/emuproc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/emu10k1/emuproc.c b/sound/pci/emu10k1/emuproc.c
index f3caa3f..216f974 100644
--- a/sound/pci/emu10k1/emuproc.c
+++ b/sound/pci/emu10k1/emuproc.c
@@ -412,7 +412,7 @@ static void snd_emu_proc_emu1010_reg_read(struct snd_info_entry *entry,
 				     struct snd_info_buffer *buffer)
 {
 	struct snd_emu10k1 *emu = entry->private_data;
-	int value;
+	u32 value;
 	unsigned long flags;
 	int i;
 	snd_iprintf(buffer, "EMU1010 Registers:\n\n");
-- 
1.5.4.3.342.g99e8



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/8] sound: emuproc.c fix signedness warning
  2008-02-28 19:11 [PATCH 1/8] sound: emuproc.c fix signedness warning Harvey Harrison
@ 2008-02-29 11:05 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-02-29 11:05 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: LKML

At Thu, 28 Feb 2008 11:11:12 -0800,
Harvey Harrison wrote:
> 
> Reading regs from the fpga into an int instead of a u32, trivial
> fix.
> sound/pci/emu10k1/emuproc.c:422:34: warning: incorrect type in argument 3 (different signedness)
> sound/pci/emu10k1/emuproc.c:422:34:    expected unsigned int [usertype] *value
> sound/pci/emu10k1/emuproc.c:422:34:    got int *<noident>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Thanks, all applied to ALSA tree (with trivial coding-style fixes --
could you run checkpatch.pl at the next time and fix the issues
together?)


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-29 11:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-28 19:11 [PATCH 1/8] sound: emuproc.c fix signedness warning Harvey Harrison
2008-02-29 11:05 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).