From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754103AbYKGHP3@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754103AbYKGHP3 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 7 Nov 2008 02:15:29 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751189AbYKGHPU
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 7 Nov 2008 02:15:20 -0500
Received: from mx2.suse.de ([195.135.220.15]:48594 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751168AbYKGHPT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Nov 2008 02:15:19 -0500
Date: Fri, 07 Nov 2008 08:15:18 +0100
Message-ID: <s5hk5bgqa61.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: alsa-devel@alsa-project.org, Mike Frysinger <vapier@gentoo.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: have snd_BUG_ON() always refer to	arguments
In-Reply-To: <8bd0f97a0811062309m4029f612k4d3fe380e6d124df@mail.gmail.com>
References: <1226023521-10037-1-git-send-email-vapier@gentoo.org>
	<s5hod0sqcmt.wl%tiwai@suse.de>
	<8bd0f97a0811062309m4029f612k4d3fe380e6d124df@mail.gmail.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 7 Nov 2008 02:09:04 -0500,
Mike Frysinger wrote:
> 
> On Fri, Nov 7, 2008 at 01:22, Takashi Iwai wrote:
> > At Thu,  6 Nov 2008 21:05:21 -0500,
> > Mike Frysinger wrote:
> >> The snd_BUG_ON() macro should always expand its argument even if we're
> >> forcing it to false.  This kills off unused warnings that did not exist
> >> before the snd_assert() -> snd_BUG_ON() conversion.
> >
> > Andrew already change this differently.  Check with the latest version.
> 
> what are you defining as "latest version" ?  i'm looking in torvalds
> linux-2.6.git.

git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

> > And which warning did you get actually?
> 
> a few codecs define local vars which only get used in snd_BUG_ON() ...
> so if snd_BUG_ON() doesnt utilize cond, gcc whines that the var is
> unused.

I know it.  But I thought all these were removed in the actual codes.
I'd like to see the real warning messages.


thanks,

Takashi