LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Manuel Jander <mjander@embedded.cl>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] au88x0: mem leak fix in snd_vortex_create()
Date: Mon, 06 Aug 2007 14:06:23 +0200	[thread overview]
Message-ID: <s5hk5s8q340.wl%tiwai@suse.de> (raw)
In-Reply-To: <200708040209.25589.jesper.juhl@gmail.com>

At Sat, 4 Aug 2007 02:09:25 +0200,
Jesper Juhl wrote:
> 
> Hi,
> 
> In sound/pci/au88x0/au88x0.c::snd_vortex_create() : 
> The Coverity checker found that if we allocate storage for 'chip' 
> but then leave via the  regions_out:  label, then we end up leaking 
> the storage allocated for 'chip'.
> I believe simply freeing 'chip' before the "return err;" line is 
> all we need to fix this, but please double-check me :)
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>

Thanks, applied to ALSA tree now.


Takashi

      parent reply	other threads:[~2007-08-06 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-04  0:09 Jesper Juhl
2007-08-04  9:47 ` Rene Herman
2007-08-06 12:06 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk5s8q340.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjander@embedded.cl \
    --subject='Re: [PATCH] au88x0: mem leak fix in snd_vortex_create()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).