LKML Archive on
help / color / mirror / Atom feed
From: Takashi Iwai <>
To: "Colin King" <>
Cc: <>,
	"Liam Girdwood" <>,
	"Mark Brown" <>,
	"Jaroslav Kysela" <>,
	<>, <>
Subject: Re: [PATCH][next] ASoC: cx2072x: fix integer overflow on unsigned int multiply
Date: Sat, 25 May 2019 08:25:10 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, 25 May 2019 00:25:51 +0200,
Colin King wrote:
> From: Colin Ian King <>
> In the case where frac_div larger than 96 the result of an unsigned
> multiplication overflows an unsigned int.  For example, this can
> happen when the sample_rate is 192000 and pll_input is 122.  Fix
> this by casing the first term of the mutiply to a u64. Also remove
> the extraneous parentheses around the expression.
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: a497a4363706 ("ASoC: Add support for Conexant CX2072X CODEC")
> Signed-off-by: Colin Ian King <>

Reviewed-by: Takashi Iwai <>



  reply	other threads:[~2019-05-25  6:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 22:25 Colin King
2019-05-25  6:25 ` Takashi Iwai [this message]
2019-05-28 15:06 ` Applied "ASoC: cx2072x: fix integer overflow on unsigned int multiply" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][next] ASoC: cx2072x: fix integer overflow on unsigned int multiply' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).