LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Connor McAdams" <conmanx360@gmail.com>
Cc: alsa-devel@alsa-project.org,
	"\"Jérémy Lefaure\"" <jeremy.lefaure@lse.epita.fr>,
	"Jaroslav Kysela" <perex@perex.cz>,
	o-takashi@sakamocchi.jp, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading
Date: Fri, 04 May 2018 11:40:58 +0200	[thread overview]
Message-ID: <s5hmuxflpw5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1525407594-25644-1-git-send-email-conmanx360@gmail.com>

On Fri, 04 May 2018 06:19:44 +0200,
Connor McAdams wrote:
> 
> This patch adds PCI quirk ID's for the Sound Blaster Z and Recon3Di.
> Only the currently tested ID's have been added.
> 
> This patch also adds the ability to load alternative firmwares for each
> card, the firmwares can be obtained from within the Windows driver.
> The Recon3Di uses "ctefx-r3di.bin" and the Sound Blaster Z uses
> "ctefx-sbz.bin". If the alternative firmware for the given quirk is not
> found, the original ctefx.bin will be used. This has been confirmed to
> work for both the R3Di and the SBZ.
> 
> This patch also makes the character array *dirstr a const.
> 
> Signed-off-by: Connor McAdams <conmanx360@gmail.com>

I reply here as the patch series lacks of a cover letter, as already
Sakamoto-san mentioned.

I like the patches in general.  It's a great effort for the long-time
PITA.  I already replied one minor thing I stumbled on.  But the whole
changes are specific to ca0132, so there is no big danger by the patch
series itself per se.

However, one thing to be fixed is the style you took in the series,
"put some changes commented out for the next patch".  I guess you made
it in that way for ease of splitting patches.  But of course it's
messy when you follow the patch history as a reader.

So please clean up them, move the new code to the new patch, and
resubmit as v3.  And, please give also a proper subject prefix and a
cover letter, too :)


Thanks!

Takashi

  parent reply	other threads:[~2018-05-04  9:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  4:19 Connor McAdams
2018-05-04  4:19 ` [PATCH 2/9] Add pincfg for SBZ + R3Di, add fp hp auto-detect Connor McAdams
2018-05-04  4:19 ` [PATCH 3/9] Add PCI region2 iomap for SBZ Connor McAdams
2018-05-04  4:19 ` [PATCH 4/9] Add extra exit functions for R3Di and SBZ Connor McAdams
2018-05-04  4:19 ` [PATCH 5/9] add/change helper " Connor McAdams
2018-05-04  4:19 ` [PATCH 6/9] add alt_select_in/out for R3Di + SBZ Connor McAdams
2018-05-04  4:19 ` [PATCH 7/9] Add DSP Volume set and New mixers for SBZ + R3Di Connor McAdams
2018-05-04  4:19 ` [PATCH 8/9] add ca0132_alt_set_vipsource Connor McAdams
2018-05-04  4:19 ` [PATCH 9/9] Add new control changes for SBZ + R3Di Connor McAdams
2018-05-04  4:30 ` [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading Connor McAdams
2018-05-04  8:25   ` Takashi Sakamoto
2018-05-04  9:40 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-03 21:42 Connor McAdams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmuxflpw5.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=conmanx360@gmail.com \
    --cc=jeremy.lefaure@lse.epita.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --subject='Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).