Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments

[Takashi Iwai <tiwai@suse.de>]

At Thu,  6 Nov 2008 21:05:21 -0500,
Mike Frysinger wrote:
> 
> The snd_BUG_ON() macro should always expand its argument even if we're
> forcing it to false.  This kills off unused warnings that did not exist
> before the snd_assert() -> snd_BUG_ON() conversion.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Andrew already change this differently.  Check with the latest version.
And which warning did you get actually?


thanks,

Takashi

> ---
>  include/sound/core.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 35424a9..87de9fc 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -387,7 +387,7 @@ void snd_verbose_printd(const char *file, int line, const char *format, ...)
>  
>  #define snd_printd(fmt, args...)	/* nothing */
>  #define snd_BUG()			/* nothing */
> -#define snd_BUG_ON(cond)	({/*(void)(cond);*/ 0;})  /* always false */
> +#define snd_BUG_ON(cond)	((cond) && 0)  /* always false */
>  
>  #endif /* CONFIG_SND_DEBUG */
>  
> -- 
> 1.6.0.3
>