From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754791AbYKGGWT (ORCPT ); Fri, 7 Nov 2008 01:22:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750940AbYKGGWG (ORCPT ); Fri, 7 Nov 2008 01:22:06 -0500 Received: from mx2.suse.de ([195.135.220.15]:45587 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbYKGGWE (ORCPT ); Fri, 7 Nov 2008 01:22:04 -0500 Date: Fri, 07 Nov 2008 07:22:02 +0100 Message-ID: From: Takashi Iwai To: Mike Frysinger Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments In-Reply-To: <1226023521-10037-1-git-send-email-vapier@gentoo.org> References: <1226023521-10037-1-git-send-email-vapier@gentoo.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 6 Nov 2008 21:05:21 -0500, Mike Frysinger wrote: > > The snd_BUG_ON() macro should always expand its argument even if we're > forcing it to false. This kills off unused warnings that did not exist > before the snd_assert() -> snd_BUG_ON() conversion. > > Signed-off-by: Mike Frysinger Andrew already change this differently. Check with the latest version. And which warning did you get actually? thanks, Takashi > --- > include/sound/core.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/sound/core.h b/include/sound/core.h > index 35424a9..87de9fc 100644 > --- a/include/sound/core.h > +++ b/include/sound/core.h > @@ -387,7 +387,7 @@ void snd_verbose_printd(const char *file, int line, const char *format, ...) > > #define snd_printd(fmt, args...) /* nothing */ > #define snd_BUG() /* nothing */ > -#define snd_BUG_ON(cond) ({/*(void)(cond);*/ 0;}) /* always false */ > +#define snd_BUG_ON(cond) ((cond) && 0) /* always false */ > > #endif /* CONFIG_SND_DEBUG */ > > -- > 1.6.0.3 >