LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Tony Luck <tony.luck@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c
Date: Tue, 11 Nov 2008 20:04:30 +0100	[thread overview]
Message-ID: <s5hprl2uls1.wl%tiwai@suse.de> (raw)
In-Reply-To: <4919D33C.3030101@goop.org>

At Tue, 11 Nov 2008 10:47:24 -0800,
Jeremy Fitzhardinge wrote:
> 
> Takashi Iwai wrote:
> > At Tue, 11 Nov 2008 09:43:27 -0800,
> > Jeremy Fitzhardinge wrote:
> >   
> >> Isaku Yamahata wrote:
> >>     
> >>> Here is.
> >>>
> >>> __initdata and const cannot be always a happy pair and
> >>> x86 xen has the potential issue.
> >>> This patch simply removes const from data with __initdata
> >>> under arch/x86/xen/.
> >>>   
> >>>       
> >> No, I think the proper fix is to use __initconst.
> >>     
> >
> > The problem is that it depends on gcc version which section it goes.
> > Thus __initconst could break some gcc versions as well.
> >   
> 
> Why?  __initconst explicitly puts it in .init.rodata.

Hrm, right, that's what __initconst does.  Just confused.
Then I'm wondering in which case __initconst can be broken...
Sam?  Do you have any particular reports?


Takashi

  reply	other threads:[~2008-11-11 19:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 16:48 Takashi Iwai
2008-11-06 18:57 ` Jeremy Fitzhardinge
2008-11-06 19:15   ` Takashi Iwai
2008-11-06 21:48   ` Sam Ravnborg
2008-11-11  7:51     ` Takashi Iwai
2008-11-11  8:15       ` Isaku Yamahata
2008-11-11  8:18         ` Takashi Iwai
2008-11-11  8:56           ` Isaku Yamahata
2008-11-11 17:43             ` Jeremy Fitzhardinge
2008-11-11 17:45               ` Takashi Iwai
2008-11-11 18:47                 ` Jeremy Fitzhardinge
2008-11-11 19:04                   ` Takashi Iwai [this message]
2008-11-12 18:19                     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hprl2uls1.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tony.luck@intel.com \
    --cc=yamahata@valinux.co.jp \
    --subject='Re: [PATCH] Fix section type conflict in arch/ia64/xen/xen_pv_ops.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).