LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch
Date: Sun, 29 Oct 2006 17:52:11 +0000 (UTC) [thread overview]
Message-ID: <slrnek9qv0.2vm.olecom@flower.upol.cz> (raw)
In-Reply-To: <200610290816.55886.ak@suse.de>
On 2006-10-29, Andi Kleen wrote:
>> Why not use -o /dev/null, as Daniel Drake already suggested in [1]? In
>> both as-instr and ld-option, the tmp file is being deleted
>> unconditionally right after its creation anyways.
>
> Because then when the compilation runs as root some as versions
> will delete /dev/null on a error. This has happened in the past.
OK, but let users, who still build kernels as root, alone.
In `19-rc3/include/Kbuild.include', just below `as-instr' i see:
,--
|cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
| > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
|
|# cc-option-yn
|# Usage: flag := $(call cc-option-yn, -march=winchip-c6)
|cc-option-yn = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
| > /dev/null 2>&1; then echo "y"; else echo "n"; fi;)
`--
so, change to `-o /dev/null' in `as-instr' will just follow this.
____
next prev parent reply other threads:[~2006-10-29 17:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 23:07 Horst Schirmeier
2006-10-29 2:07 ` Andi Kleen
2006-10-29 12:08 ` Horst Schirmeier
2006-10-29 16:16 ` Andi Kleen
2006-10-29 17:52 ` Oleg Verych [this message]
2006-10-29 22:52 ` Sam Ravnborg
2006-10-30 8:16 ` Jan Beulich
2006-10-30 13:16 ` Oleg Verych
[not found] ` <45460E6C.76E4.0078.0@novell.com>
2006-10-30 14:42 ` Oleg Verych
2006-10-30 15:22 ` Valdis.Kletnieks
2006-10-30 16:06 ` Oleg Verych
2006-10-30 22:12 ` Oleg Verych
2006-10-31 0:12 ` Horst Schirmeier
2006-10-31 0:19 ` Andi Kleen
2006-10-31 1:14 ` Horst Schirmeier
2006-10-31 13:51 ` Oleg Verych
2006-11-02 12:46 ` Jan Peter den Heijer
2006-11-17 5:17 ` kbuild: O= with M= (Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch) Oleg Verych
2007-01-23 7:36 ` [fix, rfc] " Oleg Verych
2007-01-24 8:54 ` [patch] kbuild: improving option checking " Oleg Verych
2007-01-24 16:06 ` Randy Dunlap
2007-01-24 19:28 ` [patch] spell 4 kbuild: improving option checking Oleg Verych
2006-10-31 0:27 ` [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch Horst Schirmeier
2006-10-31 13:32 ` Oleg Verych
2006-11-15 14:17 ` kbuild-mm: $(objtree)/knull vs mktemp (was Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch) Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=slrnek9qv0.2vm.olecom@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).