LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] `make help' in build tree doesn't show headers_* targets
@ 2007-01-29 12:47 Geert Uytterhoeven
  2007-01-29 14:30 ` Oleg Verych
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2007-01-29 12:47 UTC (permalink / raw)
  To: Sam Ravnborg, Linus Torvalds, Andrew Morton; +Cc: Linux Kernel Development

`make help' in the build tree doesn't show the help texts about the
`headers_install' and `headers_check' targets because it looks for
include/asm-$(ARCH)/Kbuild in the wrong place.
Add the missing `$(srctree)' prefixes to fix this.
Also move the printing of the default install path for the headers inside the
`if/fi', where it belongs.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

--- ps3-linux-src-2.6.20-rc6.orig/Makefile
+++ ps3-linux-src-2.6.20-rc6/Makefile
@@ -1116,15 +1116,15 @@ help:
 	@echo  '  cscope	  - Generate cscope index'
 	@echo  '  kernelrelease	  - Output the release version string'
 	@echo  '  kernelversion	  - Output the version stored in Makefile'
-	@if [ -r include/asm-$(ARCH)/Kbuild ]; then \
+	@if [ -r $(srctree)/include/asm-$(ARCH)/Kbuild ]; then \
 	 echo  '  headers_install - Install sanitised kernel headers to INSTALL_HDR_PATH'; \
+	 echo  '                    (default: $(INSTALL_HDR_PATH))'; \
 	 fi
-	@echo  '                    (default: $(INSTALL_HDR_PATH))'
 	@echo  ''
 	@echo  'Static analysers'
 	@echo  '  checkstack      - Generate a list of stack hogs'
 	@echo  '  namespacecheck  - Name space analysis on compiled kernel'
-	@if [ -r include/asm-$(ARCH)/Kbuild ]; then \
+	@if [ -r $(srctree)/include/asm-$(ARCH)/Kbuild ]; then \
 	 echo  '  headers_check   - Sanity check on exported headers'; \
 	 fi
 	@echo  ''

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] `make help' in build tree doesn't show headers_* targets
  2007-01-29 12:47 [PATCH] `make help' in build tree doesn't show headers_* targets Geert Uytterhoeven
@ 2007-01-29 14:30 ` Oleg Verych
  0 siblings, 0 replies; 2+ messages in thread
From: Oleg Verych @ 2007-01-29 14:30 UTC (permalink / raw)
  To: linux-kernel


> From: Geert Uytterhoeven
> Newsgroups: gmane.linux.kernel
> Subject: [PATCH] `make help' in build tree doesn't show headers_* targets
> Date: Mon, 29 Jan 2007 13:47:01 +0100 (CET)

> `make help' in the build tree doesn't show the help texts about the
> `headers_install' and `headers_check' targets because it looks for
> include/asm-$(ARCH)/Kbuild in the wrong place.
> Add the missing `$(srctree)' prefixes to fix this.
> Also move the printing of the default install path for the headers inside the
> `if/fi', where it belongs.
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
>  Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Oleg Verych <olecom@flower.upol.cz>


> --- ps3-linux-src-2.6.20-rc6.orig/Makefile
> +++ ps3-linux-src-2.6.20-rc6/Makefile
> @@ -1116,15 +1116,15 @@ help:
>  	@echo  '  cscope	  - Generate cscope index'
>  	@echo  '  kernelrelease	  - Output the release version string'
>  	@echo  '  kernelversion	  - Output the version stored in Makefile'
> -	@if [ -r include/asm-$(ARCH)/Kbuild ]; then \
> +	@if [ -r $(srctree)/include/asm-$(ARCH)/Kbuild ]; then \
>  	 echo  '  headers_install - Install sanitised kernel headers to INSTALL_HDR_PATH'; \
> +	 echo  '                    (default: $(INSTALL_HDR_PATH))'; \
>  	 fi
> -	@echo  '                    (default: $(INSTALL_HDR_PATH))'
>  	@echo  ''
>  	@echo  'Static analysers'
>  	@echo  '  checkstack      - Generate a list of stack hogs'
>  	@echo  '  namespacecheck  - Name space analysis on compiled kernel'
> -	@if [ -r include/asm-$(ARCH)/Kbuild ]; then \
> +	@if [ -r $(srctree)/include/asm-$(ARCH)/Kbuild ]; then \
>  	 echo  '  headers_check   - Sanity check on exported headers'; \
>  	 fi
>  	@echo  ''
>
> Gr{oetje,eeting}s,
>
> 						Geert
>
> --
> Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
> Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
> Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-29 14:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-29 12:47 [PATCH] `make help' in build tree doesn't show headers_* targets Geert Uytterhoeven
2007-01-29 14:30 ` Oleg Verych

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).