LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clocksource: Move inline keyword to the beginning of function declarations
@ 2019-05-24 10:33 Mathieu Malaterre
  2019-06-14 15:16 ` [tip:timers/core] " tip-bot for Mathieu Malaterre
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2019-05-24 10:33 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: trivial, kernel-janitors, Mathieu Malaterre, John Stultz,
	Stephen Boyd, linux-kernel

The inline keyword was not at the beginning of the function declarations.
Fix the following warnings triggered when using W=1:

  kernel/time/clocksource.c:108:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
  kernel/time/clocksource.c:113:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 kernel/time/clocksource.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 3bcc19ceb073..fff5f64981c6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -105,12 +105,12 @@ static DEFINE_SPINLOCK(watchdog_lock);
 static int watchdog_running;
 static atomic_t watchdog_reset_pending;
 
-static void inline clocksource_watchdog_lock(unsigned long *flags)
+static inline void clocksource_watchdog_lock(unsigned long *flags)
 {
 	spin_lock_irqsave(&watchdog_lock, *flags);
 }
 
-static void inline clocksource_watchdog_unlock(unsigned long *flags)
+static inline void clocksource_watchdog_unlock(unsigned long *flags)
 {
 	spin_unlock_irqrestore(&watchdog_lock, *flags);
 }
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:timers/core] clocksource: Move inline keyword to the beginning of function declarations
  2019-05-24 10:33 [PATCH] clocksource: Move inline keyword to the beginning of function declarations Mathieu Malaterre
@ 2019-06-14 15:16 ` tip-bot for Mathieu Malaterre
  0 siblings, 0 replies; 3+ messages in thread
From: tip-bot for Mathieu Malaterre @ 2019-06-14 15:16 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: malat, linux-kernel, tglx, john.stultz, mingo, hpa, sboyd

Commit-ID:  0f48b41f597e3b62b649abbf796e1e72901f9df3
Gitweb:     https://git.kernel.org/tip/0f48b41f597e3b62b649abbf796e1e72901f9df3
Author:     Mathieu Malaterre <malat@debian.org>
AuthorDate: Fri, 24 May 2019 12:33:39 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Jun 2019 17:04:03 +0200

clocksource: Move inline keyword to the beginning of function declarations

The inline keyword was not at the beginning of the function declarations.
Fix the following warnings triggered when using W=1:

  kernel/time/clocksource.c:108:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
  kernel/time/clocksource.c:113:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: trivial@kernel.org
Cc: kernel-janitors@vger.kernel.org
Cc: John Stultz <john.stultz@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20190524103339.28787-1-malat@debian.org

---
 kernel/time/clocksource.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 3bcc19ceb073..fff5f64981c6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -105,12 +105,12 @@ static DEFINE_SPINLOCK(watchdog_lock);
 static int watchdog_running;
 static atomic_t watchdog_reset_pending;
 
-static void inline clocksource_watchdog_lock(unsigned long *flags)
+static inline void clocksource_watchdog_lock(unsigned long *flags)
 {
 	spin_lock_irqsave(&watchdog_lock, *flags);
 }
 
-static void inline clocksource_watchdog_unlock(unsigned long *flags)
+static inline void clocksource_watchdog_unlock(unsigned long *flags)
 {
 	spin_unlock_irqrestore(&watchdog_lock, *flags);
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:timers/core] clocksource: Move inline keyword to the beginning of function declarations
  2018-05-16 19:59 [PATCH] clocksource: Move the inline keyword at " Mathieu Malaterre
@ 2018-05-16 20:24 ` tip-bot for Mathieu Malaterre
  0 siblings, 0 replies; 3+ messages in thread
From: tip-bot for Mathieu Malaterre @ 2018-05-16 20:24 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: tglx, mingo, sboyd, john.stultz, hpa, linux-kernel, malat

Commit-ID:  db6f9e55c8d80a4a1a329b9b68a1d370bffb6aad
Gitweb:     https://git.kernel.org/tip/db6f9e55c8d80a4a1a329b9b68a1d370bffb6aad
Author:     Mathieu Malaterre <malat@debian.org>
AuthorDate: Wed, 16 May 2018 21:59:43 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 16 May 2018 22:21:32 +0200

clocksource: Move inline keyword to the beginning of function declarations

The inline keyword was not at the beginning of the function declarations.
Fix the following warnings triggered when using W=1:

  kernel/time/clocksource.c:456:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
  kernel/time/clocksource.c:457:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: John Stultz <john.stultz@linaro.org>
Link: https://lkml.kernel.org/r/20180516195943.31924-1-malat@debian.org

---
 kernel/time/clocksource.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 56fd2239674f..f89a78e2792b 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -442,8 +442,8 @@ static inline int __clocksource_watchdog_work(void) { return 0; }
 static bool clocksource_is_watchdog(struct clocksource *cs) { return false; }
 void clocksource_mark_unstable(struct clocksource *cs) { }
 
-static void inline clocksource_watchdog_lock(unsigned long *flags) { }
-static void inline clocksource_watchdog_unlock(unsigned long *flags) { }
+static inline void clocksource_watchdog_lock(unsigned long *flags) { }
+static inline void clocksource_watchdog_unlock(unsigned long *flags) { }
 
 #endif /* CONFIG_CLOCKSOURCE_WATCHDOG */
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-14 15:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24 10:33 [PATCH] clocksource: Move inline keyword to the beginning of function declarations Mathieu Malaterre
2019-06-14 15:16 ` [tip:timers/core] " tip-bot for Mathieu Malaterre
  -- strict thread matches above, loose matches on Subject: below --
2018-05-16 19:59 [PATCH] clocksource: Move the inline keyword at " Mathieu Malaterre
2018-05-16 20:24 ` [tip:timers/core] clocksource: Move inline keyword to " tip-bot for Mathieu Malaterre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).