LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] perf build: Suppress warning about missing libbabeltrace
@ 2015-03-27 10:11 Jiri Olsa
  2015-03-27 11:18 ` Ingo Molnar
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Olsa @ 2015-03-27 10:11 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: David Ahern, Frederic Weisbecker, Ingo Molnar, Jeremie Galarneau,
	Namhyung Kim, Paul Mackerras, Peter Zijlstra,
	Sebastian Andrzej Siewior, Tom Zanussi, Wang Nan, lkml

Be silent about missing babeltrace library until the needed
version (1.3) is pushed into most common distros.

Requested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/n/tip-95mcd8hoxyt43jighilggjej@git.kernel.org
---
 tools/perf/config/Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index cd121dfc4de9..2d9142b10cd3 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -606,7 +606,12 @@ ifndef NO_LIBBABELTRACE
     EXTLIBS += -lbabeltrace-ctf
     $(call detected,CONFIG_LIBBABELTRACE)
   else
-    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
+#
+# Be silent about missing babeltrace library
+# until the needed version (1.3) is pushed
+# into most common distros.
+#
+#    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
     NO_LIBBABELTRACE := 1
   endif
 endif
-- 
1.9.3


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf build: Suppress warning about missing libbabeltrace
  2015-03-27 10:11 [PATCH] perf build: Suppress warning about missing libbabeltrace Jiri Olsa
@ 2015-03-27 11:18 ` Ingo Molnar
  2015-03-27 13:30   ` Jiri Olsa
  0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2015-03-27 11:18 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker,
	Jeremie Galarneau, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
	Sebastian Andrzej Siewior, Tom Zanussi, Wang Nan, lkml


* Jiri Olsa <jolsa@kernel.org> wrote:

> Be silent about missing babeltrace library until the needed
> version (1.3) is pushed into most common distros.
> 
> Requested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Link: http://lkml.kernel.org/n/tip-95mcd8hoxyt43jighilggjej@git.kernel.org
> ---
>  tools/perf/config/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index cd121dfc4de9..2d9142b10cd3 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -606,7 +606,12 @@ ifndef NO_LIBBABELTRACE
>      EXTLIBS += -lbabeltrace-ctf
>      $(call detected,CONFIG_LIBBABELTRACE)
>    else
> -    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> +#
> +# Be silent about missing babeltrace library
> +# until the needed version (1.3) is pushed
> +# into most common distros.
> +#
> +#    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
>      NO_LIBBABELTRACE := 1
>    endif
>  endif

But, but ... the feature detection is still executed, and it slows 
down the regular build on 99.9999% of the systems, right?

I don't mind carrying the code, but could we make it such that it 
needs some special option to build or so?

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf build: Suppress warning about missing libbabeltrace
  2015-03-27 11:18 ` Ingo Molnar
@ 2015-03-27 13:30   ` Jiri Olsa
  2015-03-28  9:03     ` Ingo Molnar
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Olsa @ 2015-03-27 13:30 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Jiri Olsa, Arnaldo Carvalho de Melo, David Ahern,
	Frederic Weisbecker, Jeremie Galarneau, Namhyung Kim,
	Paul Mackerras, Peter Zijlstra, Sebastian Andrzej Siewior,
	Tom Zanussi, Wang Nan, lkml

On Fri, Mar 27, 2015 at 12:18:55PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@kernel.org> wrote:
> 
> > Be silent about missing babeltrace library until the needed
> > version (1.3) is pushed into most common distros.
> > 
> > Requested-by: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Link: http://lkml.kernel.org/n/tip-95mcd8hoxyt43jighilggjej@git.kernel.org
> > ---
> >  tools/perf/config/Makefile | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> > index cd121dfc4de9..2d9142b10cd3 100644
> > --- a/tools/perf/config/Makefile
> > +++ b/tools/perf/config/Makefile
> > @@ -606,7 +606,12 @@ ifndef NO_LIBBABELTRACE
> >      EXTLIBS += -lbabeltrace-ctf
> >      $(call detected,CONFIG_LIBBABELTRACE)
> >    else
> > -    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> > +#
> > +# Be silent about missing babeltrace library
> > +# until the needed version (1.3) is pushed
> > +# into most common distros.
> > +#
> > +#    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> >      NO_LIBBABELTRACE := 1
> >    endif
> >  endif
> 
> But, but ... the feature detection is still executed, and it slows 
> down the regular build on 99.9999% of the systems, right?
> 

right, so currently all features are being checked by default and the
only way to disable the check is via NO_* make variables

> I don't mind carrying the code, but could we make it such that it 
> needs some special option to build or so?

I thought about this as of generic feature for all checks, but given
that this is the only case so far, how about attached patch?

it's changing the NO_LIBBABELTRACE to LIBBABELTRACE so the libbabeltrace
check is disabled unless you do:

  $ make LIBBABELTRACE=1

and we'd switch it back once the babeltrace 1.3 is in generic use

jirka


---
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index e9925e6ad1d0..c43a20517591 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -69,7 +69,7 @@ include config/utilities.mak
 #
 # Define NO_ZLIB if you do not want to support compressed kernel modules
 #
-# Define NO_LIBBABELTRACE if you do not want libbabeltrace support
+# Define LIBBABELTRACE if you DO want libbabeltrace support
 # for CTF data format.
 #
 # Define NO_LZMA if you do not want to support compressed (xz) kernel modules
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index cd121dfc4de9..59a98c643240 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -95,7 +95,7 @@ ifndef NO_LIBELF
   FEATURE_CHECK_LDFLAGS-libdw-dwarf-unwind := $(LIBDW_LDFLAGS) -ldw
 endif
 
-ifndef NO_LIBBABELTRACE
+ifdef LIBBABELTRACE
   # for linking with debug library, run like:
   # make DEBUG=1 LIBBABELTRACE_DIR=/opt/libbabeltrace/
   ifdef LIBBABELTRACE_DIR
@@ -598,7 +598,7 @@ else
   NO_PERF_READ_VDSOX32 := 1
 endif
 
-ifndef NO_LIBBABELTRACE
+ifdef LIBBABELTRACE
   $(call feature_check,libbabeltrace)
   ifeq ($(feature-libbabeltrace), 1)
     CFLAGS += -DHAVE_LIBBABELTRACE_SUPPORT $(LIBBABELTRACE_CFLAGS)
@@ -607,7 +607,6 @@ ifndef NO_LIBBABELTRACE
     $(call detected,CONFIG_LIBBABELTRACE)
   else
     msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
-    NO_LIBBABELTRACE := 1
   endif
 endif
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf build: Suppress warning about missing libbabeltrace
  2015-03-27 13:30   ` Jiri Olsa
@ 2015-03-28  9:03     ` Ingo Molnar
  2015-03-28 10:30       ` [PATCH] perf build: Disable libbabeltrace check by default Jiri Olsa
  0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2015-03-28  9:03 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Jiri Olsa, Arnaldo Carvalho de Melo, David Ahern,
	Frederic Weisbecker, Jeremie Galarneau, Namhyung Kim,
	Paul Mackerras, Peter Zijlstra, Sebastian Andrzej Siewior,
	Tom Zanussi, Wang Nan, lkml


* Jiri Olsa <jolsa@redhat.com> wrote:

> On Fri, Mar 27, 2015 at 12:18:55PM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@kernel.org> wrote:
> > 
> > > Be silent about missing babeltrace library until the needed
> > > version (1.3) is pushed into most common distros.
> > > 
> > > Requested-by: Ingo Molnar <mingo@kernel.org>
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > Link: http://lkml.kernel.org/n/tip-95mcd8hoxyt43jighilggjej@git.kernel.org
> > > ---
> > >  tools/perf/config/Makefile | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> > > index cd121dfc4de9..2d9142b10cd3 100644
> > > --- a/tools/perf/config/Makefile
> > > +++ b/tools/perf/config/Makefile
> > > @@ -606,7 +606,12 @@ ifndef NO_LIBBABELTRACE
> > >      EXTLIBS += -lbabeltrace-ctf
> > >      $(call detected,CONFIG_LIBBABELTRACE)
> > >    else
> > > -    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> > > +#
> > > +# Be silent about missing babeltrace library
> > > +# until the needed version (1.3) is pushed
> > > +# into most common distros.
> > > +#
> > > +#    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> > >      NO_LIBBABELTRACE := 1
> > >    endif
> > >  endif
> > 
> > But, but ... the feature detection is still executed, and it slows 
> > down the regular build on 99.9999% of the systems, right?
> > 
> 
> right, so currently all features are being checked by default and the
> only way to disable the check is via NO_* make variables
> 
> > I don't mind carrying the code, but could we make it such that it 
> > needs some special option to build or so?
> 
> I thought about this as of generic feature for all checks, but given
> that this is the only case so far, how about attached patch?
> 
> it's changing the NO_LIBBABELTRACE to LIBBABELTRACE so the libbabeltrace
> check is disabled unless you do:
> 
>   $ make LIBBABELTRACE=1
> 
> and we'd switch it back once the babeltrace 1.3 is in generic use

That sounds good to me!

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] perf build: Disable libbabeltrace check by default
  2015-03-28  9:03     ` Ingo Molnar
@ 2015-03-28 10:30       ` Jiri Olsa
  2015-04-02 12:23         ` [tip:perf/core] " tip-bot for Jiri Olsa
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Olsa @ 2015-03-28 10:30 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Jiri Olsa, Arnaldo Carvalho de Melo, David Ahern,
	Frederic Weisbecker, Jeremie Galarneau, Namhyung Kim,
	Paul Mackerras, Peter Zijlstra, Sebastian Andrzej Siewior,
	Tom Zanussi, Wang Nan, lkml

On Sat, Mar 28, 2015 at 10:03:28AM +0100, Ingo Molnar wrote:

SNIP

> > 
> > I thought about this as of generic feature for all checks, but given
> > that this is the only case so far, how about attached patch?
> > 
> > it's changing the NO_LIBBABELTRACE to LIBBABELTRACE so the libbabeltrace
> > check is disabled unless you do:
> > 
> >   $ make LIBBABELTRACE=1
> > 
> > and we'd switch it back once the babeltrace 1.3 is in generic use
> 
> That sounds good to me!
> 
> Acked-by: Ingo Molnar <mingo@kernel.org>
> 
> Thanks,
> 
> 	Ingo

attached same patch with full changelog

thanks,
jirka


---
Disabling libbabeltrace check by default and replacing the
NO_LIBBABELTRACE make variable with LIBBABELTRACE.

Users wanting the libbabeltrace feature need to build via:
  $ make LIBBABELTRACE=1

The reason for this is that the libababeltrace interface
we use (version 1.3) hasn't been packaged/released yet,
thus the failing feature check only slows down build and
confuses other (non CTF) developers.

Requested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Ingo Molnar <mingo@kernel.org>
Link: http://lkml.kernel.org/n/tip-1i0bqo6zi4p52utgj2ihfg1i@git.kernel.org
---
 tools/perf/Makefile.perf   | 2 +-
 tools/perf/config/Makefile | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index e9925e6ad1d0..c43a20517591 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -69,7 +69,7 @@ include config/utilities.mak
 #
 # Define NO_ZLIB if you do not want to support compressed kernel modules
 #
-# Define NO_LIBBABELTRACE if you do not want libbabeltrace support
+# Define LIBBABELTRACE if you DO want libbabeltrace support
 # for CTF data format.
 #
 # Define NO_LZMA if you do not want to support compressed (xz) kernel modules
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index cd121dfc4de9..59a98c643240 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -95,7 +95,7 @@ ifndef NO_LIBELF
   FEATURE_CHECK_LDFLAGS-libdw-dwarf-unwind := $(LIBDW_LDFLAGS) -ldw
 endif
 
-ifndef NO_LIBBABELTRACE
+ifdef LIBBABELTRACE
   # for linking with debug library, run like:
   # make DEBUG=1 LIBBABELTRACE_DIR=/opt/libbabeltrace/
   ifdef LIBBABELTRACE_DIR
@@ -598,7 +598,7 @@ else
   NO_PERF_READ_VDSOX32 := 1
 endif
 
-ifndef NO_LIBBABELTRACE
+ifdef LIBBABELTRACE
   $(call feature_check,libbabeltrace)
   ifeq ($(feature-libbabeltrace), 1)
     CFLAGS += -DHAVE_LIBBABELTRACE_SUPPORT $(LIBBABELTRACE_CFLAGS)
@@ -607,7 +607,6 @@ ifndef NO_LIBBABELTRACE
     $(call detected,CONFIG_LIBBABELTRACE)
   else
     msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
-    NO_LIBBABELTRACE := 1
   endif
 endif
 
-- 
1.9.3


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [tip:perf/core] perf build: Disable libbabeltrace check by default
  2015-03-28 10:30       ` [PATCH] perf build: Disable libbabeltrace check by default Jiri Olsa
@ 2015-04-02 12:23         ` tip-bot for Jiri Olsa
  0 siblings, 0 replies; 6+ messages in thread
From: tip-bot for Jiri Olsa @ 2015-04-02 12:23 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: fweisbec, dsahern, jolsa, namhyung, jgalar, hpa, mingo, paulus,
	a.p.zijlstra, jolsa, tglx, linux-kernel, acme, wangnan0,
	tzanussi, bigeasy

Commit-ID:  6ab2b762befd192b90704c5c7898f5abf8ebb387
Gitweb:     http://git.kernel.org/tip/6ab2b762befd192b90704c5c7898f5abf8ebb387
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Sat, 28 Mar 2015 11:30:30 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 30 Mar 2015 10:24:27 -0300

perf build: Disable libbabeltrace check by default

Disabling libbabeltrace check by default and replacing the
NO_LIBBABELTRACE make variable with LIBBABELTRACE.

Users wanting the libbabeltrace feature need to build via:

  $ make LIBBABELTRACE=1

The reason for this is that the libababeltrace interface we use (version
1.3) hasn't been packaged/released yet, thus the failing feature check
only slows down build and confuses other (non CTF) developers.

Requested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jeremie Galarneau <jgalar@efficios.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20150328103030.GA8431@krava.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf   | 2 +-
 tools/perf/config/Makefile | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index e9925e6..c43a205 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -69,7 +69,7 @@ include config/utilities.mak
 #
 # Define NO_ZLIB if you do not want to support compressed kernel modules
 #
-# Define NO_LIBBABELTRACE if you do not want libbabeltrace support
+# Define LIBBABELTRACE if you DO want libbabeltrace support
 # for CTF data format.
 #
 # Define NO_LZMA if you do not want to support compressed (xz) kernel modules
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index cd121df..59a98c6 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -95,7 +95,7 @@ ifndef NO_LIBELF
   FEATURE_CHECK_LDFLAGS-libdw-dwarf-unwind := $(LIBDW_LDFLAGS) -ldw
 endif
 
-ifndef NO_LIBBABELTRACE
+ifdef LIBBABELTRACE
   # for linking with debug library, run like:
   # make DEBUG=1 LIBBABELTRACE_DIR=/opt/libbabeltrace/
   ifdef LIBBABELTRACE_DIR
@@ -598,7 +598,7 @@ else
   NO_PERF_READ_VDSOX32 := 1
 endif
 
-ifndef NO_LIBBABELTRACE
+ifdef LIBBABELTRACE
   $(call feature_check,libbabeltrace)
   ifeq ($(feature-libbabeltrace), 1)
     CFLAGS += -DHAVE_LIBBABELTRACE_SUPPORT $(LIBBABELTRACE_CFLAGS)
@@ -607,7 +607,6 @@ ifndef NO_LIBBABELTRACE
     $(call detected,CONFIG_LIBBABELTRACE)
   else
     msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
-    NO_LIBBABELTRACE := 1
   endif
 endif
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-04-02 12:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-27 10:11 [PATCH] perf build: Suppress warning about missing libbabeltrace Jiri Olsa
2015-03-27 11:18 ` Ingo Molnar
2015-03-27 13:30   ` Jiri Olsa
2015-03-28  9:03     ` Ingo Molnar
2015-03-28 10:30       ` [PATCH] perf build: Disable libbabeltrace check by default Jiri Olsa
2015-04-02 12:23         ` [tip:perf/core] " tip-bot for Jiri Olsa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).