LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: tip-bot for Davidlohr Bueso <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jason.low2@hp.com,
paulmck@linux.vnet.ibm.com, dave@stgolabs.net,
tglx@linutronix.de, torvalds@linux-foundation.org,
dbueso@suse.de, hpa@zytor.com, peterz@infradead.org,
walken@google.com, tim.c.chen@linux.intel.com, mingo@kernel.org
Subject: [tip:locking/core] locking/rwsem: Use task->state helpers
Date: Wed, 4 Feb 2015 06:38:22 -0800 [thread overview]
Message-ID: <tip-73105994c57d06e40a33ab5a716db04e898b4c05@git.kernel.org> (raw)
In-Reply-To: <1422257769-14083-2-git-send-email-dave@stgolabs.net>
Commit-ID: 73105994c57d06e40a33ab5a716db04e898b4c05
Gitweb: http://git.kernel.org/tip/73105994c57d06e40a33ab5a716db04e898b4c05
Author: Davidlohr Bueso <dave@stgolabs.net>
AuthorDate: Sun, 25 Jan 2015 23:36:04 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 4 Feb 2015 07:57:39 +0100
locking/rwsem: Use task->state helpers
Call __set_task_state() instead of assigning the new state
directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP
environments, keeping track of who last changed the state.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Jason Low <jason.low2@hp.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1422257769-14083-2-git-send-email-dave@stgolabs.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/locking/rwsem-spinlock.c | 2 +-
kernel/locking/rwsem-xadd.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/locking/rwsem-spinlock.c b/kernel/locking/rwsem-spinlock.c
index 2c93571..2555ae1 100644
--- a/kernel/locking/rwsem-spinlock.c
+++ b/kernel/locking/rwsem-spinlock.c
@@ -154,7 +154,7 @@ void __sched __down_read(struct rw_semaphore *sem)
set_task_state(tsk, TASK_UNINTERRUPTIBLE);
}
- tsk->state = TASK_RUNNING;
+ __set_task_state(tsk, TASK_RUNNING);
out:
;
}
diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c
index 7628c3f..2f7cc40 100644
--- a/kernel/locking/rwsem-xadd.c
+++ b/kernel/locking/rwsem-xadd.c
@@ -242,8 +242,7 @@ struct rw_semaphore __sched *rwsem_down_read_failed(struct rw_semaphore *sem)
schedule();
}
- tsk->state = TASK_RUNNING;
-
+ __set_task_state(tsk, TASK_RUNNING);
return sem;
}
EXPORT_SYMBOL(rwsem_down_read_failed);
next prev parent reply other threads:[~2015-02-04 14:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 7:36 [PATCH -tip 0/6] rwsem: Fine tuning Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 1/6] locking/rwsem: Use task->state helpers Davidlohr Bueso
2015-02-04 14:38 ` tip-bot for Davidlohr Bueso [this message]
2015-01-26 7:36 ` [PATCH 2/6] locking/rwsem: Document barrier need when waking tasks Davidlohr Bueso
2015-01-27 17:07 ` Peter Zijlstra
2015-01-27 20:30 ` Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 3/6] locking/rwsem: Set lock ownership ASAP Davidlohr Bueso
2015-01-27 17:10 ` Peter Zijlstra
2015-01-27 19:18 ` Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 4/6] locking/rwsem: Avoid deceiving lock spinners Davidlohr Bueso
2015-01-27 17:23 ` Jason Low
2015-01-28 3:54 ` Davidlohr Bueso
2015-01-28 17:01 ` Tim Chen
2015-01-28 21:03 ` Jason Low
2015-01-29 1:10 ` Davidlohr Bueso
2015-01-29 20:13 ` Jason Low
2015-01-29 20:18 ` Jason Low
2015-01-29 23:15 ` Davidlohr Bueso
2015-01-30 1:52 ` Refactoring mutex spin on owner code Jason Low
2015-01-30 7:14 ` Davidlohr Bueso
2015-01-30 7:51 ` Peter Zijlstra
2015-01-26 7:36 ` [PATCH 5/6] locking/rwsem: Optimize slowpath/sleeping Davidlohr Bueso
2015-01-27 17:34 ` Peter Zijlstra
2015-01-27 21:57 ` Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 6/6] locking/rwsem: Check for active lock before bailing on spinning Davidlohr Bueso
2015-01-27 18:11 ` Jason Low
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-73105994c57d06e40a33ab5a716db04e898b4c05@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=hpa@zytor.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--subject='Re: [tip:locking/core] locking/rwsem: Use task->state helpers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).