From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753454AbbDBM2e (ORCPT ); Thu, 2 Apr 2015 08:28:34 -0400 Received: from terminus.zytor.com ([198.137.202.10]:60560 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752723AbbDBM22 (ORCPT ); Thu, 2 Apr 2015 08:28:28 -0400 Date: Thu, 2 Apr 2015 05:28:12 -0700 From: tip-bot for Stefan Lippers-Hollmann Message-ID: Cc: mingo@kernel.org, tglx@linutronix.de, matt.fleming@intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, s.l-h@gmx.de, stable@vger.kernel.org Reply-To: mingo@kernel.org, stable@vger.kernel.org, s.l-h@gmx.de, tglx@linutronix.de, matt.fleming@intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org In-Reply-To: <20150330224427.0fb58e42@mir> References: <20150330224427.0fb58e42@mir> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/reboot: Add ASRock Q1900DC-ITX mainboard reboot quirk Git-Commit-ID: 80313b3078fcd2ca51970880d90757f05879a193 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 80313b3078fcd2ca51970880d90757f05879a193 Gitweb: http://git.kernel.org/tip/80313b3078fcd2ca51970880d90757f05879a193 Author: Stefan Lippers-Hollmann AuthorDate: Mon, 30 Mar 2015 22:44:27 +0200 Committer: Ingo Molnar CommitDate: Wed, 1 Apr 2015 14:08:09 +0200 x86/reboot: Add ASRock Q1900DC-ITX mainboard reboot quirk The ASRock Q1900DC-ITX mainboard (Baytrail-D) hangs randomly in both BIOS and UEFI mode while rebooting unless reboot=pci is used. Add a quirk to reboot via the pci method. The problem is very intermittent and hard to debug, it might succeed rebooting just fine 40 times in a row - but fails half a dozen times the next day. It seems to be slightly less common in BIOS CSM mode than native UEFI (with the CSM disabled), but it does happen in either mode. Since I've started testing this patch in late january, rebooting has been 100% reliable. Most of the time it already hangs during POST, but occasionally it might even make it through the bootloader and the kernel might even start booting, but then hangs before the mode switch. The same symptoms occur with grub-efi, gummiboot and grub-pc, just as well as (at least) kernel 3.16-3.19 and 4.0-rc6 (I haven't tried older kernels than 3.16). Upgrading to the most current mainboard firmware of the ASRock Q1900DC-ITX, version 1.20, does not improve the situation. ( Searching the web seems to suggest that other Bay Trail-D mainboards might be affected as well. ) -- Signed-off-by: Stefan Lippers-Hollmann Cc: Cc: Matt Fleming Link: http://lkml.kernel.org/r/20150330224427.0fb58e42@mir Signed-off-by: Ingo Molnar --- arch/x86/kernel/reboot.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index bae6c60..86db4bc 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -183,6 +183,16 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = { }, }, + /* ASRock */ + { /* Handle problems with rebooting on ASRock Q1900DC-ITX */ + .callback = set_pci_reboot, + .ident = "ASRock Q1900DC-ITX", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASRock"), + DMI_MATCH(DMI_BOARD_NAME, "Q1900DC-ITX"), + }, + }, + /* ASUS */ { /* Handle problems with rebooting on ASUS P4S800 */ .callback = set_bios_reboot,