LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: tip-bot for Xunlei Pang <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: peterz@infradead.org, tglx@linutronix.de, torvalds@linux-foundation.org, mingo@kernel.org, pang.xunlei@linaro.org, juri.lelli@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: [tip:sched/core] sched/deadline: Remove cpu_active_mask from cpudl_find() Date: Wed, 4 Feb 2015 06:36:10 -0800 [thread overview] Message-ID: <tip-9659e1eeee28f7025b6545934d644d19e9c6e603@git.kernel.org> (raw) In-Reply-To: <1421642980-10045-2-git-send-email-pang.xunlei@linaro.org> Commit-ID: 9659e1eeee28f7025b6545934d644d19e9c6e603 Gitweb: http://git.kernel.org/tip/9659e1eeee28f7025b6545934d644d19e9c6e603 Author: Xunlei Pang <pang.xunlei@linaro.org> AuthorDate: Mon, 19 Jan 2015 04:49:37 +0000 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 4 Feb 2015 07:52:29 +0100 sched/deadline: Remove cpu_active_mask from cpudl_find() cpu_active_mask is rarely changed (only on hotplug), so remove this operation to gain a little performance. If there is a change in cpu_active_mask, rq_online_dl() and rq_offline_dl() should take care of it normally, so cpudl::free_cpus carries enough information for us. For the rare case when a task is put onto a dying cpu (which rq_offline_dl() can't handle in a timely fashion), it will be handled through _cpu_down()->...->multi_cpu_stop()->migration_call() ->migrate_tasks(), preventing the task from hanging on the dead cpu. Cc: Juri Lelli <juri.lelli@gmail.com> Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org> [peterz: changelog] Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: http://lkml.kernel.org/r/1421642980-10045-2-git-send-email-pang.xunlei@linaro.org Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/cpudeadline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c index fd9d3fb..c6acb07 100644 --- a/kernel/sched/cpudeadline.c +++ b/kernel/sched/cpudeadline.c @@ -108,8 +108,7 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p, const struct sched_dl_entity *dl_se = &p->dl; if (later_mask && - cpumask_and(later_mask, cp->free_cpus, &p->cpus_allowed) && - cpumask_and(later_mask, later_mask, cpu_active_mask)) { + cpumask_and(later_mask, cp->free_cpus, &p->cpus_allowed)) { best_cpu = cpumask_any(later_mask); goto out; } else if (cpumask_test_cpu(cpudl_maximum(cp), &p->cpus_allowed) &&
next prev parent reply other threads:[~2015-02-04 14:36 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-19 4:49 [PATCH 1/5] sched/deadline: Modify cpudl::free_cpus to reflect rd->online Xunlei Pang 2015-01-19 4:49 ` [PATCH 2/5] sched/deadline: Remove cpu_active_mask from cpudl_find() Xunlei Pang 2015-01-27 15:04 ` Peter Zijlstra 2015-02-04 14:36 ` tip-bot for Xunlei Pang [this message] 2015-01-19 4:49 ` [PATCH 3/5] sched/deadline: Fix wrong cpudl_find() in check_preempt_equal_dl() Xunlei Pang 2015-01-27 12:48 ` Peter Zijlstra 2015-01-27 14:15 ` Peter Zijlstra 2015-01-27 16:47 ` Peter Zijlstra 2015-01-28 15:18 ` Xunlei Pang 2015-01-19 4:49 ` [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri_find() Xunlei Pang 2015-01-27 12:58 ` Peter Zijlstra 2015-01-27 14:18 ` Peter Zijlstra 2015-01-27 23:04 ` Steven Rostedt 2015-01-28 15:21 ` Xunlei Pang 2015-01-19 4:49 ` [PATCH 5/5] sched/rt: Optimize find_lowest_rq() to select a cache hot cpu Xunlei Pang 2015-01-27 14:21 ` Peter Zijlstra 2015-01-27 14:56 ` Steven Rostedt 2015-01-27 16:28 ` Peter Zijlstra 2015-01-29 16:42 ` Xunlei Pang 2015-01-29 17:17 ` Steven Rostedt 2015-01-29 19:23 ` Peter Zijlstra 2015-02-04 13:07 ` Xunlei Pang 2015-01-23 18:09 ` [PATCH 1/5] sched/deadline: Modify cpudl::free_cpus to reflect rd->online Xunlei Pang 2015-02-01 17:53 ` [tip:sched/core] sched/deadline: Modify cpudl:: free_cpus " tip-bot for Xunlei Pang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-9659e1eeee28f7025b6545934d644d19e9c6e603@git.kernel.org \ --to=tipbot@zytor.com \ --cc=hpa@zytor.com \ --cc=juri.lelli@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=pang.xunlei@linaro.org \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).