LKML Archive on
help / color / mirror / Atom feed
* [tip:perf/urgent] perf hists browser: Remove leftover from row returned from refresh
@ 2018-04-10  5:29 tip-bot for Arnaldo Carvalho de Melo
  0 siblings, 0 replies; only message in thread
From: tip-bot for Arnaldo Carvalho de Melo @ 2018-04-10  5:29 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: acme, wangnan0, yao.jin, tglx, jolsa, adrian.hunter,
	linux-kernel, hpa, namhyung, dsahern, mingo, ak

Commit-ID:  94e87a8bd529121ea90219164c65c36ea1d19e56
Author:     Arnaldo Carvalho de Melo <>
AuthorDate: Fri, 6 Apr 2018 12:11:11 -0300
Committer:  Arnaldo Carvalho de Melo <>
CommitDate: Fri, 6 Apr 2018 12:23:25 -0300

perf hists browser: Remove leftover from row returned from refresh

The per-browser screen refresh routine (ui_browser->refresh()) should
return the first row that should be cleaned after the rows just printed,
in case not all rows available on the screen gets filled.

When moving the extra title lines logic from the hists browser to the
generic ui_browser class, one piece of that logic remained in the hists
browser and then when going back from the annotate browser to the hists
browser in a case where fewer lines were displayed in the hists browser,
for instance when filtering the entries per substring, one line of the
annotate browser would remain on the screen, fix that.

Example of the screen artifact:

Samples: 73K of event 'cycles:ppp', 4000 Hz, Event count (approx.): 45172901394
Overhead  Shared O  Symbol
   0.30%  [kernel]  [k] __indirect_thunk_start
   0.09%  [kernel]  [k] __x86_indirect_thunk_r10
       │      lfence

Here from 'perf top' the view was zoomed with '/thunk' to functions
having that substring, then the first was annotated and from the
annotate browser ESC was pressed, then the first lines were overwritten,
but the 'lfence' line remained due to the off by one bug fixed in this

Cc: Adrian Hunter <>
Cc: Andi Kleen <>
Cc: David Ahern <>
Cc: Jin Yao <>
Cc: Jiri Olsa <>
Cc: Namhyung Kim <>
Cc: Wang Nan <>
Fixes: ef9ff6017e3c ("perf ui browser: Move the extra title lines from the hists browser")
Signed-off-by: Arnaldo Carvalho de Melo <>
 tools/perf/ui/browsers/hists.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index de17e59d9952..0eec06c105c6 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1744,17 +1744,11 @@ static void ui_browser__hists_init_top(struct ui_browser *browser)
 static unsigned int hist_browser__refresh(struct ui_browser *browser)
 	unsigned row = 0;
-	u16 header_offset = 0;
 	struct rb_node *nd;
 	struct hist_browser *hb = container_of(browser, struct hist_browser, b);
-	struct hists *hists = hb->hists;
-	if (hb->show_headers) {
-		struct perf_hpp_list *hpp_list = hists->hpp_list;
+	if (hb->show_headers)
-		header_offset = hpp_list->nr_header_lines;
-	}
 	hb->he_selection = NULL;
@@ -1792,7 +1786,7 @@ static unsigned int hist_browser__refresh(struct ui_browser *browser)
-	return row + header_offset;
+	return row;
 static struct rb_node *hists__filter_entries(struct rb_node *nd,

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-04-10  5:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10  5:29 [tip:perf/urgent] perf hists browser: Remove leftover from row returned from refresh tip-bot for Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).