LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] firewire: fw-sbp2: reduce log noise
Date: Thu, 28 Feb 2008 20:53:45 +0100 (CET)	[thread overview]
Message-ID: <tkrat.e91ea76ee0e2c394@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.efdb1b5f8ccb3cbd@s5r6.in-berlin.de>

The block/unblock logic is now sufficiently tested.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

To be postponed after 2.6.25.

 drivers/firewire/fw-sbp2.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Index: linux/drivers/firewire/fw-sbp2.c
===================================================================
--- linux.orig/drivers/firewire/fw-sbp2.c
+++ linux/drivers/firewire/fw-sbp2.c
@@ -687,10 +687,8 @@ static void sbp2_conditionally_block(str
 	if (!tgt->dont_block && !lu->blocked &&
 	    lu->generation != card->generation) {
 		lu->blocked = true;
-		if (++tgt->blocked == 1) {
+		if (++tgt->blocked == 1)
 			scsi_block_requests(shost);
-			fw_notify("blocked %s\n", lu->tgt->bus_id);
-		}
 	}
 	spin_unlock_irqrestore(&card->lock, flags);
 }
@@ -717,10 +715,8 @@ static void sbp2_conditionally_unblock(s
 	}
 	spin_unlock_irqrestore(&card->lock, flags);
 
-	if (unblock) {
+	if (unblock)
 		scsi_unblock_requests(shost);
-		fw_notify("unblocked %s\n", lu->tgt->bus_id);
-	}
 }
 
 /*

-- 
Stefan Richter
-=====-==--- --=- ===--
http://arcgraph.de/sr/


      parent reply	other threads:[~2008-02-28 19:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 19:50 [PATCH 0/4] firewire: trivial fw-sbp2 updates Stefan Richter
2008-02-28 19:51 ` [PATCH 1/4] firewire: fw-sbp2: remove usages of fw_memcpy_to_be32 Stefan Richter
2008-02-28 19:52 ` [PATCH 2/4] firewire: fw-sbp2: simplify some macros Stefan Richter
2008-02-28 19:52 ` [PATCH 3/4] firewire: fw-sbp2: remove unnecessary memset Stefan Richter
2008-02-28 19:53 ` Stefan Richter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.e91ea76ee0e2c394@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --subject='Re: [PATCH 4/4] firewire: fw-sbp2: reduce log noise' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).