From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbXCUARa (ORCPT ); Tue, 20 Mar 2007 20:17:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752276AbXCUARa (ORCPT ); Tue, 20 Mar 2007 20:17:30 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:54460 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbXCUAR3 convert rfc822-to-8bit (ORCPT ); Tue, 20 Mar 2007 20:17:29 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Wed, 21 Mar 2007 01:16:10 +0100 (CET) From: Stefan Richter Subject: Re: [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion To: Greg KH cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, Ismail D?nmez , Adrian Bunk , Thomas Meyer , Tobias Diedrich In-Reply-To: <20070320233432.GA20228@kroah.com> Message-ID: References: <200703140642.28390.ismail@pardus.org.tr> <200703150051.29945.ismail@pardus.org.tr> <45F88E8B.90403@s5r6.in-berlin.de> <200703150249.04169.ismail@pardus.org.tr> <20070320233432.GA20228@kroah.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=iso-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: INLINE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 20 Mar, Greg KH wrote: > On Tue, Mar 20, 2007 at 10:43:22PM +0100, Stefan Richter wrote: >> @@ -586,7 +586,10 @@ static void ether1394_add_host (struct h >> } >> >> SET_MODULE_OWNER(dev); >> +#if 0 >> + /* FIXME - Is this the correct parent device anyway? */ >> SET_NETDEV_DEV(dev, &host->device); >> +#endif > > That's interesting. What does 'tree /sys/class/net/' look like with > this patch applied? Does the eth1394 device now live off in > /sys/device/virtual? Yes. lrwxrwxrwx 1 root root 0 Mär 21 01:02 eth0 -> ../../devices/pci0000:00/0000:00:0b.0/eth0/ lrwxrwxrwx 1 root root 0 Mär 21 01:02 eth1 -> ../../devices/virtual/net/eth1/ lrwxrwxrwx 1 root root 0 Mär 21 01:02 lo -> ../../devices/virtual/net/lo/ (eth1 is IP over 1394 alias eth1394. eth0 is an actual ethernet interface.) And eth1/device (ex -> ../../../devices/pci*___*/fw-host*) is now gone. Would anybody miss it? > If so, I guess this is ok for now as we can wait for the rewrite of the > ieee1394 subsystem to get the linking done correctly :) That's my hope too. -- Stefan Richter -=====-=-=== --== =-=-= http://arcgraph.de/sr/