LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Piotr Witoslawski <pwitos@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	Yannis Damigos <giannis.damigos@gmail.com>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] drivers: staging: rtl8723au: fix "warning: cast to restricted __le16"
Date: Thu, 02 Apr 2015 06:17:48 -0400	[thread overview]
Message-ID: <wrfja8yqbzqr.fsf@redhat.com> (raw)
In-Reply-To: <20150402100756.GH10964@mwanda> (Dan Carpenter's message of "Thu, 2 Apr 2015 13:07:56 +0300")

Dan Carpenter <dan.carpenter@oracle.com> writes:
> This doesn't look right and it doesn't have a changelog explainly the
> weirdness.
>

... and the fix is as ugly as it gets!

If something like this is needed, creating a __le16 *ptr at the
beginnging of the function would be a lot better.

Jes

  reply	other threads:[~2015-04-02 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  9:37 Piotr Witoslawski
2015-04-02 10:07 ` Dan Carpenter
2015-04-02 10:17   ` Jes Sorensen [this message]
2015-04-02 13:37 ` [PATCH v2] " Piotr Witoslawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfja8yqbzqr.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=giannis.damigos@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pwitos@gmail.com \
    --subject='Re: [PATCH] drivers: staging: rtl8723au: fix "warning: cast to restricted __le16"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).