From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbbDBKSG (ORCPT ); Thu, 2 Apr 2015 06:18:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39507 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbbDBKSE (ORCPT ); Thu, 2 Apr 2015 06:18:04 -0400 From: Jes Sorensen To: Dan Carpenter Cc: Piotr Witoslawski , Larry Finger , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Yannis Damigos , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] drivers: staging: rtl8723au: fix "warning: cast to restricted __le16" References: <20150402093748.GA24455@pwitoslawski.warsaw.osa> <20150402100756.GH10964@mwanda> Date: Thu, 02 Apr 2015 06:17:48 -0400 In-Reply-To: <20150402100756.GH10964@mwanda> (Dan Carpenter's message of "Thu, 2 Apr 2015 13:07:56 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter writes: > This doesn't look right and it doesn't have a changelog explainly the > weirdness. > ... and the fix is as ugly as it gets! If something like this is needed, creating a __le16 *ptr at the beginnging of the function would be a lot better. Jes