From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755653AbbHFMVz (ORCPT ); Thu, 6 Aug 2015 08:21:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36229 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755591AbbHFMVx (ORCPT ); Thu, 6 Aug 2015 08:21:53 -0400 From: Jes Sorensen To: Johannes Postma Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , Greg Kroah-Hartman Subject: Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16 References: <1438860112-1786-1-git-send-email-jgmpostma@gmail.com> Date: Thu, 06 Aug 2015 08:21:51 -0400 In-Reply-To: <1438860112-1786-1-git-send-email-jgmpostma@gmail.com> (Johannes Postma's message of "Thu, 6 Aug 2015 12:21:52 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes Postma writes: > usPtr is used as __le16 *, but was defined as u16 *. > This was reported by sparse as: > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to > restricted __le16 > > This patch fixes the type of usPtr. > > Signed-off-by: Johannes Postma > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks OK to me. Probably worth changing the *(usPtr + index) to be usPtr[index] as well to make the code easier to read. Jes > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > index cb5076a..eb76ac4 100644 > --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > @@ -1838,7 +1838,7 @@ Hal_EfuseParseThermalMeter_8723A(struct rtw_adapter *padapter, > > static void rtl8723a_cal_txdesc_chksum(struct tx_desc *ptxdesc) > { > - u16 *usPtr = (u16 *) ptxdesc; > + __le16 *usPtr = (__le16 *)ptxdesc; > u32 count = 16; /* (32 bytes / 2 bytes per XOR) => 16 times */ > u32 index; > u16 checksum = 0;