LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Stefan Strogin <s.strogin@partner.samsung.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	aneesh.kumar@linux.vnet.ibm.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dmitry Safonov <d.safonov@partner.samsung.com>,
	Pintu Kumar <pintu.k@samsung.com>,
	Weijie Yang <weijie.yang@samsung.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	SeongJae Park <sj38.park@gmail.com>, Hui Zhu <zhuhui@xiaomi.com>,
	Minchan Kim <minchan@kernel.org>,
	Dyasly Sergey <s.dyasly@samsung.com>,
	Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
	Aleksei Mateosian <a.mateosian@samsung.com>,
	gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com,
	pavel@ucw.cz, stefan.strogin@gmail.com
Subject: Re: [PATCH v3 3/4] mm: cma: add list of currently allocated CMA buffers to debugfs
Date: Mon, 02 Mar 2015 21:42:28 +0100	[thread overview]
Message-ID: <xa1tk2yz2ksr.fsf@mina86.com> (raw)
In-Reply-To: <54F48560.1090800@partner.samsung.com>

On Mon, Mar 02 2015, Stefan Strogin <s.strogin@partner.samsung.com> wrote:
> My fault. You are right.
> I'm not sure how to do the output nice... I could use *ppos to point the
> number of next list entry to read (like that is used in
> read_page_owner()). But in this case the list could be changed before we
> finish reading, it's bad.
> Or we could use seq_files like in v1, iterating over buffer_list
> entries. But seq_print_stack_trace() has to be added.

I’m not that familiar with seq_* so my opinion may be ill-informed, but
I feel that skipping some entries while (de)allocations happen is akin
to process reading a file while some other process modifies it.  This is
a debug function so perhaps it’s acceptable that it may return garbage
if not used carefully?

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--

  reply	other threads:[~2015-03-02 20:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 18:44 [PATCH v3 0/4] mm: cma: add some debug information for CMA Stefan Strogin
2015-02-24 18:44 ` [PATCH v3 1/4] mm: cma: add trace events to debug physically-contiguous memory allocations Stefan Strogin
2015-02-24 21:14   ` Michal Nazarewicz
2015-03-03  9:13   ` Aneesh Kumar K.V
2015-03-05 14:33     ` Stefan Strogin
2015-02-24 18:44 ` [PATCH v3 2/4] mm: cma: add number of pages to debug message in cma_release() Stefan Strogin
2015-02-24 21:15   ` Michal Nazarewicz
2015-02-24 18:44 ` [PATCH v3 3/4] mm: cma: add list of currently allocated CMA buffers to debugfs Stefan Strogin
2015-02-24 21:32   ` Michal Nazarewicz
2015-03-02 15:44     ` Stefan Strogin
2015-03-02 20:42       ` Michal Nazarewicz [this message]
2015-03-03  9:16   ` Aneesh Kumar K.V
2015-03-10 13:28     ` Stefan Strogin
2015-03-17 10:23       ` Aneesh Kumar K.V
2015-02-24 18:44 ` [PATCH v3 4/4] mm: cma: add functions to get region pages counters Stefan Strogin
2015-02-24 21:34   ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1tk2yz2ksr.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=a.mateosian@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=d.safonov@partner.samsung.com \
    --cc=gioh.kim@lge.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=lauraa@codeaurora.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=minchan@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pintu.k@samsung.com \
    --cc=s.dyasly@samsung.com \
    --cc=s.strogin@partner.samsung.com \
    --cc=sasha.levin@oracle.com \
    --cc=sj38.park@gmail.com \
    --cc=stefan.strogin@gmail.com \
    --cc=v.tyrtov@samsung.com \
    --cc=weijie.yang@samsung.com \
    --cc=zhuhui@xiaomi.com \
    --subject='Re: [PATCH v3 3/4] mm: cma: add list of currently allocated CMA buffers to debugfs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).