LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@cavium.com,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] scsi: qedf: remove memset/memcpy to nfunc and use func instead
Date: Thu, 18 Apr 2019 20:33:21 -0400	[thread overview]
Message-ID: <yq11s1ydeb2.fsf@oracle.com> (raw)
In-Reply-To: <20190412094829.15868-1-colin.king@canonical.com> (Colin King's message of "Fri, 12 Apr 2019 10:48:29 +0100")


Colin,

> Currently the qedf_dbg_* family of functions can overrun the end of
> the source string if it is less than the destination buffer length
> because of the use of a fixed sized memcpy. Remove the memset/memcpy
> calls to nfunc and just use func instead as it is always a null
> terminated string.

Applied to 5.2/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2019-04-19  0:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  9:48 Colin King
2019-04-18  8:13 ` Saurav Kashyap
2019-04-19  0:33 ` Martin K. Petersen [this message]
2019-04-20  4:05 ` [PATCH] scsi: qedi: " Yue Haibing
2019-05-09 14:50   ` YueHaibing
2019-05-10 11:29   ` Dan Carpenter
2019-05-13 22:31   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq11s1ydeb2.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=colin.king@canonical.com \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --subject='Re: [PATCH][V2] scsi: qedf: remove memset/memcpy to nfunc and use func instead' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).