LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2021-08-24  6:34 ` Stephen Rothwell
  2021-08-24  6:43   ` Alim Akhtar
  2021-08-25  2:45   ` Martin K. Petersen
  0 siblings, 2 replies; 15+ messages in thread
From: Stephen Rothwell @ 2021-08-24  6:34 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Alim Akhtar, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi all,

In commit

  2b7661aa3f28 ("scsi: ufs: ufs-exynos: Fix static checker warning")

Fixes tag

  Fixes: 55f4b1f73631: "scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs"

has these problem(s):

  - missing space between the SHA1 and the subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2021-08-24  6:34 ` linux-next: Fixes tag needs some work in the scsi-mkp tree Stephen Rothwell
@ 2021-08-24  6:43   ` Alim Akhtar
  2021-08-25  2:45   ` Martin K. Petersen
  1 sibling, 0 replies; 15+ messages in thread
From: Alim Akhtar @ 2021-08-24  6:43 UTC (permalink / raw)
  To: 'Stephen Rothwell', 'Martin K. Petersen'
  Cc: 'Linux Kernel Mailing List', 'Linux Next Mailing List'

Hi

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: 24 August 2021 12:05
> To: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>
> Subject: linux-next: Fixes tag needs some work in the scsi-mkp tree
> 
> Hi all,
> 
> In commit
> 
>   2b7661aa3f28 ("scsi: ufs: ufs-exynos: Fix static checker warning")
> 
> Fixes tag
> 
>   Fixes: 55f4b1f73631: "scsi: ufs: ufs-exynos: Add UFS host support for
Exynos
> SoCs"
> 
Sorry about this.
Martin,
You want me to re-send the patch or you will take care?
 
> has these problem(s):
> 
>   - missing space between the SHA1 and the subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> --
> Cheers,
> Stephen Rothwell


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2021-08-24  6:34 ` linux-next: Fixes tag needs some work in the scsi-mkp tree Stephen Rothwell
  2021-08-24  6:43   ` Alim Akhtar
@ 2021-08-25  2:45   ` Martin K. Petersen
  1 sibling, 0 replies; 15+ messages in thread
From: Martin K. Petersen @ 2021-08-25  2:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Alim Akhtar, Linux Kernel Mailing List,
	Linux Next Mailing List


Stephen,

>   Fixes: 55f4b1f73631: "scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs"

My validation hook didn't catch this, the regex wasn't expecting a ':'
trailing the [[:xdigit:]]+.

Tweaked my script and fixed the tag.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2021-11-04  4:37 Stephen Rothwell
@ 2021-11-05  2:50 ` Martin K. Petersen
  0 siblings, 0 replies; 15+ messages in thread
From: Martin K. Petersen @ 2021-11-05  2:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Tadeusz Struk, Linux Kernel Mailing List,
	Linux Next Mailing List


Stephen,

>   Fixes: 2ceda20f0a99a74a82b78870f3b3e5fa93087a7f

Interesting. A recent subtle tweak to my commit hook's regex resulted in
it no longer matching when the subject was missing. Sorry about that!
Fixed it up.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2021-11-04  4:37 Stephen Rothwell
  2021-11-05  2:50 ` Martin K. Petersen
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2021-11-04  4:37 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Tadeusz Struk, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi all,

In commit

  559a5d048ec3 ("scsi: core: Remove command size deduction from scsi_setup_scsi_cmnd()")

Fixes tag

  Fixes: 2ceda20f0a99a74a82b78870f3b3e5fa93087a7f

has these problem(s):

  - missing subject

Pleas just use

git log -1 --format='Fixes: %h ("%s")' <commit>

so

Fixes: 2ceda20f0a99 ("scsi: core: Move command size detection out of the fast path")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2020-08-18  6:11 Stephen Rothwell
@ 2020-08-18  6:46 ` Can Guo
  0 siblings, 0 replies; 15+ messages in thread
From: Can Guo @ 2020-08-18  6:46 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

On 2020-08-18 14:11, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   35afe60929ab ("scsi: ufs: Properly release resources if a task is
> aborted successfully")
> 
> Fixes tag
> 
>   Fixes: 5a0b0cb9bee7 ("ufs: Add support for clock gating")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did you mean
> 
> Fixes: 5a0b0cb9bee7 ("[SCSI] ufs: Add support for sending NOP OUT 
> UPIU")
> 
> or
> 
> Fixes: 1ab27c9cf8b6 ("ufs: Add support for clock gating")

Thanks for pointing it out, it should be below one, something
might go wrong with my copy-paste.

Fixes: 1ab27c9cf8b6 ("ufs: Add support for clock gating")

Regards,

Can Guo.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2020-08-18  6:11 Stephen Rothwell
  2020-08-18  6:46 ` Can Guo
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2020-08-18  6:11 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Can Guo

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi all,

In commit

  35afe60929ab ("scsi: ufs: Properly release resources if a task is aborted successfully")

Fixes tag

  Fixes: 5a0b0cb9bee7 ("ufs: Add support for clock gating")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 5a0b0cb9bee7 ("[SCSI] ufs: Add support for sending NOP OUT UPIU")

or

Fixes: 1ab27c9cf8b6 ("ufs: Add support for clock gating")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2019-12-20  5:19 Stephen Rothwell
@ 2019-12-21 18:43 ` Martin K. Petersen
  0 siblings, 0 replies; 15+ messages in thread
From: Martin K. Petersen @ 2019-12-21 18:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Quinn Tran, Himanshu Madhani


Stephen,

> Fixes tag
>
>   Fixes: 974950710e2a ("qla2xxx: Fix stuck login session")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: ce0ba496dccf ("scsi: qla2xxx: Fix stuck login session")

Fixed, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2019-12-20  5:19 Stephen Rothwell
  2019-12-21 18:43 ` Martin K. Petersen
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2019-12-20  5:19 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Quinn Tran,
	Himanshu Madhani

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi all,

In commit

  08c0de658b08 ("scsi: qla2xxx: Fix stuck login session using prli_pend_timer")

Fixes tag

  Fixes: 974950710e2a ("qla2xxx: Fix stuck login session")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ce0ba496dccf ("scsi: qla2xxx: Fix stuck login session")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2019-11-19  9:28 Stephen Rothwell
@ 2019-11-20  2:35 ` Martin K. Petersen
  0 siblings, 0 replies; 15+ messages in thread
From: Martin K. Petersen @ 2019-11-20  2:35 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Pan Bian


Stephen,

>   Fixes: 2a49a78ed3c ("[SCSI] qla4xxx: added IPv6 support.")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long

Fixed, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2019-11-19  9:28 Stephen Rothwell
  2019-11-20  2:35 ` Martin K. Petersen
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2019-11-19  9:28 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pan Bian

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi all,

In commit

  250f3cd01313 ("scsi: qla4xxx: fix double free bug")

Fixes tag

  Fixes: 2a49a78ed3c ("[SCSI] qla4xxx: added IPv6 support.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2019-08-29 23:40 Stephen Rothwell
  0 siblings, 0 replies; 15+ messages in thread
From: Stephen Rothwell @ 2019-08-29 23:40 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, John Pittman

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hi all,

In commit

  f18b30a01e21 ("scsi: fnic: print port speed only at driver init or speed change")

Fixes tag

  Fixes: commit d948e6383ec3 ("scsi: fnic: Add port speed stat to fnic debug stats")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-mkp tree
  2019-08-15 10:29 Stephen Rothwell
@ 2019-08-20  1:53 ` Martin K. Petersen
  0 siblings, 0 replies; 15+ messages in thread
From: Martin K. Petersen @ 2019-08-20  1:53 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Martin Wilck


Stephen,

> In commit
>
>   cff1191553d9 ("scsi: qla2xxx: cleanup trace buffer initialization")
>
> Fixes tag
>
>   Fixes: ad0a0b01f088 ("scsi: qla2xxx: Fix Firmware dump size for Extended
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please don't split Fixes tags over more than one line.
>
> Fixes tag
>
>   Fixes: (a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump
>
> has these problem(s):
>
>   - No SHA1 recognised

Fixed these up. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2019-08-15 10:29 Stephen Rothwell
  2019-08-20  1:53 ` Martin K. Petersen
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2019-08-15 10:29 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Martin Wilck

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi all,

In commit

  cff1191553d9 ("scsi: qla2xxx: cleanup trace buffer initialization")

Fixes tag

  Fixes: ad0a0b01f088 ("scsi: qla2xxx: Fix Firmware dump size for Extended

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please don't split Fixes tags over more than one line.

Fixes tag

  Fixes: (a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump

has these problem(s):

  - No SHA1 recognised

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-mkp tree
@ 2019-07-30 22:48 Stephen Rothwell
  0 siblings, 0 replies; 15+ messages in thread
From: Stephen Rothwell @ 2019-07-30 22:48 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Quinn Tran,
	Himanshu Madhani

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi all,

In commit

  d31ca849b04a ("scsi: qla2xxx: Fix Relogin to prevent modifying scan_state flag")

Fixes tag

  Fixes: 79140e2f4fa7 ("scsi: qla2xxx: Fix login state machine freeze")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 2dee5521028c ("scsi: qla2xxx: Fix login state machine freeze")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-11-05  2:50 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210824063445epcas5p4ed6e40889cf8d78edd7914284b26e852@epcas5p4.samsung.com>
2021-08-24  6:34 ` linux-next: Fixes tag needs some work in the scsi-mkp tree Stephen Rothwell
2021-08-24  6:43   ` Alim Akhtar
2021-08-25  2:45   ` Martin K. Petersen
2021-11-04  4:37 Stephen Rothwell
2021-11-05  2:50 ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2020-08-18  6:11 Stephen Rothwell
2020-08-18  6:46 ` Can Guo
2019-12-20  5:19 Stephen Rothwell
2019-12-21 18:43 ` Martin K. Petersen
2019-11-19  9:28 Stephen Rothwell
2019-11-20  2:35 ` Martin K. Petersen
2019-08-29 23:40 Stephen Rothwell
2019-08-15 10:29 Stephen Rothwell
2019-08-20  1:53 ` Martin K. Petersen
2019-07-30 22:48 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).