From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758371AbbA3Itl (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Jan 2015 03:49:41 -0500
Received: from unicorn.mansr.com ([81.2.72.234]:55604 "EHLO unicorn.mansr.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750909AbbA3Itj convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Jan 2015 03:49:39 -0500
From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        <linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] video: fbdev: fix sys_copyarea
References: <1421889589-16362-1-git-send-email-mans@mansr.com>
	<54CB38B6.3010202@ti.com>
Date: Fri, 30 Jan 2015 08:49:30 +0000
In-Reply-To: <54CB38B6.3010202@ti.com> (Tomi Valkeinen's message of "Fri, 30
	Jan 2015 09:54:30 +0200")
Message-ID: <yw1xh9v8bqlh.fsf@unicorn.mansr.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> On 22/01/15 03:19, Mans Rullgard wrote:
>> The sys_copyarea() function performs the same operation as
>> cfb_copyarea() but using normal memory access instead of I/O
>> accessors.  Since the introduction of sys_copyarea(), there
>> have been two fixes to cfb_copyarea():
>> 
>> - 00a9d699 ("framebuffer: fix cfb_copyarea")
>> - 5b789da8 ("framebuffer: fix screen corruption when copying")
>> 
>> This patch incorporates the fixes into sys_copyarea() as well.
>> 
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> ---
>> Changed in v2:
>>  - Fixed wrong first/last calculation in bitcpy_rev()
>> ---
>>  drivers/video/fbdev/core/syscopyarea.c | 137 ++++++++++++++++-----------------
>>  1 file changed, 65 insertions(+), 72 deletions(-)
>
> Thanks, queued for 3.20.
>
> This makes me wonder, though, if the sys and cfb versions could be
> somehow combined...

I would have done it by #including a common template with different
macro definitions for the memory access operations.

-- 
Måns Rullgård
mans@mansr.com