LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Fix userspace inclusion of linux/fs.h (resend)
@ 2004-05-23 18:22 Måns Rullgård
  2004-05-23 18:30 ` Jeff Garzik
  0 siblings, 1 reply; 3+ messages in thread
From: Måns Rullgård @ 2004-05-23 18:22 UTC (permalink / raw)
  To: linux-kernel; +Cc: torvalds

The patch below fixes compilation of userspace using linux/fs.h.  The
patch is against Linux 2.6.6.  Please apply of fix some other way.

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/05/16 22:34:26+02:00 mru@ford.guide 
#   fix userspace use of linux/fs.h
# 
# include/linux/fs.h
#   2004/05/16 22:28:34+02:00 mru@ford.guide +3 -3
#   move some #includes inside #ifdef __KERNEL__ to allow userspace inclusion
# 
diff -Nru a/include/linux/fs.h b/include/linux/fs.h
--- a/include/linux/fs.h	2004-05-23 20:11:46 +02:00
+++ b/include/linux/fs.h	2004-05-23 20:11:46 +02:00
@@ -13,14 +13,11 @@
 #include <linux/types.h>
 #include <linux/kdev_t.h>
 #include <linux/ioctl.h>
-#include <linux/list.h>
 #include <linux/dcache.h>
 #include <linux/stat.h>
 #include <linux/cache.h>
-#include <linux/radix-tree.h>
 #include <linux/kobject.h>
 #include <asm/atomic.h>
-#include <linux/audit.h>
 
 struct iovec;
 struct nameidata;
@@ -213,6 +210,9 @@
 
 #ifdef __KERNEL__
 
+#include <linux/list.h>
+#include <linux/radix-tree.h>
+#include <linux/audit.h>
 #include <asm/semaphore.h>
 #include <asm/byteorder.h>
 

-- 
Måns Rullgård
mru@kth.se

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix userspace inclusion of linux/fs.h (resend)
  2004-05-23 18:22 [PATCH] Fix userspace inclusion of linux/fs.h (resend) Måns Rullgård
@ 2004-05-23 18:30 ` Jeff Garzik
  2004-05-23 19:04   ` Måns Rullgård
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2004-05-23 18:30 UTC (permalink / raw)
  To: Måns Rullgård; +Cc: linux-kernel, torvalds

Måns Rullgård wrote:
> The patch below fixes compilation of userspace using linux/fs.h.  The
> patch is against Linux 2.6.6.  Please apply of fix some other way.


Userspace should not be directly including the kernel headers.

Some dude maintains a "linux-libc-headers" package, you probably want that.

	Jeff



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix userspace inclusion of linux/fs.h (resend)
  2004-05-23 18:30 ` Jeff Garzik
@ 2004-05-23 19:04   ` Måns Rullgård
  0 siblings, 0 replies; 3+ messages in thread
From: Måns Rullgård @ 2004-05-23 19:04 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-kernel, torvalds

Jeff Garzik <jgarzik@pobox.com> writes:

> Måns Rullgård wrote:
>> The patch below fixes compilation of userspace using linux/fs.h.  The
>> patch is against Linux 2.6.6.  Please apply of fix some other way.
>
> Userspace should not be directly including the kernel headers.
>
> Some dude maintains a "linux-libc-headers" package, you probably want that.

I still fail to see the point in maintaining three separate sets of
header files, but that has been discussed in the past.

-- 
Måns Rullgård
mru@kth.se

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-05-23 19:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-23 18:22 [PATCH] Fix userspace inclusion of linux/fs.h (resend) Måns Rullgård
2004-05-23 18:30 ` Jeff Garzik
2004-05-23 19:04   ` Måns Rullgård

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).