Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Cc: unlisted-recipients:; (no To-header on input)
	keitasuzuki.park@sslab.ics.keio.ac.jp,
	takafumi@sslab.ics.keio.ac.jp,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
	Wright Feng <wright.feng@cypress.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy
Date: Wed, 9 Sep 2020 07:32:47 +0000	[thread overview]
Message-ID: <0101017471c8011a-8c36c26e-bef6-438b-b4d7-3e423983ac30-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <20200908121743.23108-1-keitasuzuki.park@sslab.ics.keio.ac.jp>

Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp> wrote:

> When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy,
> the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be
> freed in the caller function.
> 
> Fix this by calling wlc_phy_detach_lcnphy in the error handler of
> wlc_phy_txpwr_srom_read_lcnphy before returning.
> 
> Signed-off-by: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>

Patch applied to wireless-drivers-next.git, thanks.

f4443293d741 brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

-- 
https://patchwork.kernel.org/patch/11763749/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


      reply	other threads:[~2020-09-09  7:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 16:22 [PATCH] brcmsmac: fix potential " Keita Suzuki
2020-09-07 20:46 ` Arend Van Spriel
2020-09-08  0:13   ` [PATCH] brcmsmac: fix " Keita Suzuki
2020-09-08 11:18     ` Arend Van Spriel
2020-09-08 12:02       ` Keita Suzuki
2020-09-08 12:12         ` Arend Van Spriel
2020-09-08 12:17           ` [PATCH v2] " Keita Suzuki
2020-09-09  7:32             ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101017471c8011a-8c36c26e-bef6-438b-b4d7-3e423983ac30-000000@us-west-2.amazonses.com \
    --to=kvalo@codeaurora.org \
    --cc=keitasuzuki.park@sslab.ics.keio.ac.jp \
    --subject='Re: [PATCH v2] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).