Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <jiri@nvidia.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>, <chenhao288@hisilicon.com>
Subject: Re: [PATCH V2 net-next 1/9] devlink: add documentation for hns3 driver
Date: Mon, 19 Jul 2021 09:21:28 +0800	[thread overview]
Message-ID: <01c7a657-8454-4b2d-ded9-9212875e5e82@huawei.com> (raw)
In-Reply-To: <20210716080013.652969bf@cakuba>



On 2021/7/16 14:00, Jakub Kicinski wrote:
> On Thu, 15 Jul 2021 15:45:02 +0800, Guangbin Huang wrote:
>> From: Hao Chen <chenhao288@hisilicon.com>
>>
>> Add a file to document devlink support for hns3 driver.
>>
>> Now support devlink param and devlink info.
>>
>> Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> 
>> +This document describes the devlink features implemented by the ``hns3``
>> +device driver.
>> +
>> +Parameters
>> +==========
>> +
>> +The ``hns3`` driver implements the following driver-specific
>> +parameters.
>> +
>> +.. list-table:: Driver-specific parameters implemented
>> +   :widths: 10 10 10 70
>> +
>> +   * - Name
>> +     - Type
>> +     - Mode
>> +     - Description
>> +   * - ``rx_buf_len``
>> +     - U32
>> +     - driverinit
>> +     - Set rx BD buffer size, now only support setting 2048 and 4096.
>> +
>> +       * The feature is used to change the buffer size of each BD of Rx ring
>> +         between 2KB and 4KB, then do devlink reload operation to take effect.
> 
> Does the reload required here differ from the reload performed when the
> ring size is changed? You can extend the ethtool API, devlink params
> should be used for very vendor specific configuration. Which page
> fragment size very much is not.
>Ok, we will try to extend the ethtool API to implement this feature.
Thanks.

>> +   * - ``tx_buf_size``
>> +     - U32
>> +     - driverinit
>> +     - Set tx bounce buf size.
>> +
>> +       * The size is setted for tx bounce feature. Tx bounce buffer feature is
>> +         used for small size packet or frag. It adds a queue based tx shared
>> +         bounce buffer to memcpy the small packet when the len of xmitted skb is
>> +         below tx_copybreak(value to distinguish small size and normal size),
>> +         and reduce the overhead of dma map and unmap when IOMMU is on.
> 
> IMHO setting the tx_copybreak should be configured thru the same API as
> the size of the buffer it uses. Hence, again, ethtool.
> .
> 
Ok.

  reply	other threads:[~2021-07-19  1:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  7:45 [PATCH V2 net-next 0/9] net: hns3: add support devlink Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 1/9] devlink: add documentation for hns3 driver Guangbin Huang
2021-07-16  6:00   ` Jakub Kicinski
2021-07-19  1:21     ` huangguangbin (A) [this message]
2021-07-15  7:45 ` [PATCH V2 net-next 2/9] net: hns3: add support for registering devlink for PF Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 3/9] net: hns3: add support for registering devlink for VF Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 4/9] net: hns3: add support for devlink get info for PF Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 5/9] net: hns3: add support for devlink get info for VF Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 6/9] net: hns3: add devlink reload support for PF Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 7/9] net: hns3: add devlink reload support for VF Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 8/9] net: hns3: add support for PF setting rx/tx buffer size by devlink param Guangbin Huang
2021-07-15  7:45 ` [PATCH V2 net-next 9/9] net: hns3: add support for VF " Guangbin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01c7a657-8454-4b2d-ded9-9212875e5e82@huawei.com \
    --to=huangguangbin2@huawei.com \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH V2 net-next 1/9] devlink: add documentation for hns3 driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).