Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jiri Pirko <jiri@mellanox.com>, Jonathan Corbet <corbet@lwn.net>,
	Michael Chan <michael.chan@broadcom.com>,
	Bin Luo <luobin9@huawei.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Leon Romanovsky <leon@kernel.org>,
	Ido Schimmel <idosch@mellanox.com>,
	Danielle Ratson <danieller@mellanox.com>
Subject: RE: [net-next v3 1/4] devlink: check flash_update parameter support in net core
Date: Wed, 19 Aug 2020 15:53:32 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB58C8B9BEF6@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <20200818204540.2a278200@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>



> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, August 18, 2020 8:46 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: netdev@vger.kernel.org; Jiri Pirko <jiri@mellanox.com>; Jonathan Corbet
> <corbet@lwn.net>; Michael Chan <michael.chan@broadcom.com>; Bin Luo
> <luobin9@huawei.com>; Saeed Mahameed <saeedm@mellanox.com>; Leon
> Romanovsky <leon@kernel.org>; Ido Schimmel <idosch@mellanox.com>;
> Danielle Ratson <danieller@mellanox.com>
> Subject: Re: [net-next v3 1/4] devlink: check flash_update parameter support in
> net core
> 
> On Tue, 18 Aug 2020 17:28:15 -0700 Jacob Keller wrote:
> >  struct devlink_ops {
> > +	/**
> > +	 * @supported_flash_update_params:
> > +	 * mask of parameters supported by the driver's .flash_update
> > +	 * implemementation.
> > +	 */
> > +	u32 supported_flash_update_params;
> 
> To be sure - this doesn't generate W=1 warnings?
> 

I didn't see any pop out in devlink.c with an allyesconfig or an allmodconfig.

> Sadly the posting confused patchwork series grouping and my build tester
> (I think it's the iproute patches mixed with the kernel stuff).

Hmm. I split them up but I guess it still threaded them when I sent them. I'll just send them using two separate send-emails in the future.

Thanks,
Jake

  reply	other threads:[~2020-08-19 15:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  0:28 [net-next v3 0/4] devlink flash update overwrite mask Jacob Keller
2020-08-19  0:28 ` [net-next v3 1/4] devlink: check flash_update parameter support in net core Jacob Keller
2020-08-19  3:45   ` Jakub Kicinski
2020-08-19 15:53     ` Keller, Jacob E [this message]
2020-08-19 23:36   ` David Miller
2020-08-20  0:58     ` Jacob Keller
2020-08-19  0:28 ` [net-next v3 2/4] devlink: convert flash_update to use params structure Jacob Keller
2020-08-19  0:28 ` [net-next v3 3/4] devlink: introduce flash update overwrite mask Jacob Keller
2020-08-19  3:54   ` Jakub Kicinski
2020-08-19 16:01     ` Keller, Jacob E
2020-08-19 16:30       ` Jakub Kicinski
2020-08-19 17:06         ` Keller, Jacob E
2020-08-19  0:28 ` [net-next v3 4/4] ice: add support for " Jacob Keller
2020-08-19  0:28 ` [iproute2-next v3 0/2] devlink " Jacob Keller
2020-08-19  0:28 ` [iproute2-next v3 1/2] Update devlink header for overwrite mask attribute Jacob Keller
2020-08-19  0:28 ` [iproute2-next v3 2/2] devlink: support setting the overwrite mask Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02874ECE860811409154E81DA85FBB58C8B9BEF6@fmsmsx101.amr.corp.intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=corbet@lwn.net \
    --cc=danieller@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=luobin9@huawei.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --subject='RE: [net-next v3 1/4] devlink: check flash_update parameter support in net core' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).