Netdev Archive on
help / color / mirror / Atom feed
From: Jens Axboe <>
To: Christoph Hellwig <>, Jakub Kicinski <>
Cc: Networking <>,
	"David S. Miller" <>
Subject: Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket
Date: Mon, 7 Sep 2020 13:32:56 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/7/20 11:00 AM, Christoph Hellwig wrote:
> On Mon, Sep 07, 2020 at 09:58:13AM -0700, Jakub Kicinski wrote:
>> On Mon, 7 Sep 2020 10:45:00 -0600 Jens Axboe wrote:
>>> On 9/6/20 11:48 PM, Christoph Hellwig wrote:
>>>> On Sat, Sep 05, 2020 at 04:05:48PM -0600, Jens Axboe wrote:  
>>>>> There's a trivial io_uring patch that depends on this one. If this one
>>>>> is acceptable to you, I'd like to queue it up in the io_uring branch for
>>>>> 5.10.  
>>>> Can you give it a better name?  These __ names re just horrible.
>>>> sock_shutdown_sock?  
>>> Sure, I don't really care, just following what is mostly done already. And
>>> it is meant to be internal in the sense that it's not exported to modules.
>>> I'll let the net guys pass the final judgement on that, I'm obviously fine
>>> with anything in terms of naming :-)
>> So am I :) But if Christoph prefers sock_shutdown_sock() let's use that.
> Let's go with the original naming.  I might eventually do a big
> naming sweep in socket.c after cleaning up more of the compat mess.

Agree, saves me the hassle... FWIW, networking does have an even broader
space of func to __func to ____func and in some cases not "following" the
usual calling order of them.

Jens Axboe

      reply	other threads:[~2020-09-07 19:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 22:05 Jens Axboe
2020-09-05 22:39 ` Jakub Kicinski
2020-09-05 22:51   ` Jens Axboe
2020-09-07  5:48 ` Christoph Hellwig
2020-09-07 16:45   ` Jens Axboe
2020-09-07 16:58     ` Jakub Kicinski
2020-09-07 17:00       ` Christoph Hellwig
2020-09-07 19:32         ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).