Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Justin Iurman <justin.iurman@uliege.be>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next] ipioam6: use print_nl instead of print_null
Date: Wed, 11 Aug 2021 12:28:55 -0600	[thread overview]
Message-ID: <0c1f2466-6af5-5299-6aa9-4479cef7bd76@gmail.com> (raw)
In-Reply-To: <20210811101356.13958-1-justin.iurman@uliege.be>

On 8/11/21 4:13 AM, Justin Iurman wrote:
> This patch addresses Stephen's comment:
> 
> """
>> +        print_null(PRINT_ANY, "", "\n", NULL);
> 
> Use print_nl() since it handles the case of oneline output.
> Plus in JSON the newline is meaningless.
> """
> 
> It also removes two useless print_null's.
> 
> Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
> ---
>  ip/ipioam6.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 


applied to iproute2-next



      reply	other threads:[~2021-08-11 18:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 10:13 Justin Iurman
2021-08-11 18:28 ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c1f2466-6af5-5299-6aa9-4479cef7bd76@gmail.com \
    --to=dsahern@gmail.com \
    --cc=justin.iurman@uliege.be \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --subject='Re: [PATCH iproute2-next] ipioam6: use print_nl instead of print_null' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).