Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops
Date: Sun, 1 Aug 2021 12:35:18 +0200 [thread overview]
Message-ID: <106547ef-7a61-2064-33f5-3cc8d12adb34@gmail.com> (raw)
If a network device is runtime-suspended then:
- network device may be flagged as detached and all ethtool ops (even if
not accessing the device) will fail because netif_device_present()
returns false
- ethtool ops may fail because device is not accessible (e.g. because being
in D3 in case of a PCI device)
It may not be desirable that userspace can't use even simple ethtool ops
that not access the device if interface or link is down. To be more friendly
to userspace let's ensure that device is runtime-resumed when executing
ethtool ops in kernel.
This patch series covers the typical case that the netdev parent is power-
managed, e.g. a PCI device. Not sure whether cases exist where the netdev
itself is power-managed. If yes then we may need an extension for this.
But the series as-is at least shouldn't cause problems in that case.
Heiner Kallweit (4):
ethtool: runtime-resume netdev parent before ethtool ioctl ops
ethtool: move implementation of ethnl_ops_begin/complete to netlink.c
ethtool: move netif_device_present check from
ethnl_parse_header_dev_get to ethnl_ops_begin
ethtool: runtime-resume netdev parent in ethnl_ops_begin
net/ethtool/ioctl.c | 18 ++++++++++++++---
net/ethtool/netlink.c | 45 +++++++++++++++++++++++++++++++++++++------
net/ethtool/netlink.h | 15 ++-------------
3 files changed, 56 insertions(+), 22 deletions(-)
--
2.32.0
next reply other threads:[~2021-08-01 10:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 10:35 Heiner Kallweit [this message]
2021-08-01 10:36 ` [PATCH net-next 1/4] ethtool: runtime-resume netdev parent before ethtool ioctl ops Heiner Kallweit
2021-08-03 20:41 ` Grygorii Strashko
2021-08-03 21:32 ` Heiner Kallweit
2021-08-04 8:43 ` Grygorii Strashko
2021-08-04 19:33 ` Heiner Kallweit
2021-08-05 8:20 ` Grygorii Strashko
2021-08-05 11:11 ` Joakim Zhang
2021-08-05 11:58 ` Grygorii Strashko
2021-08-05 19:24 ` Heiner Kallweit
2021-08-05 20:00 ` Grygorii Strashko
2021-08-01 10:37 ` [PATCH net-next 2/4] ethtool: move implementation of ethnl_ops_begin/complete to netlink.c Heiner Kallweit
2021-08-01 10:40 ` [PATCH net-next 3/4] ethtool: move netif_device_present check from ethnl_parse_header_dev_get to ethnl_ops_begin Heiner Kallweit
2021-08-01 10:41 ` [PATCH net-next 4/4] ethtool: runtime-resume netdev parent in ethnl_ops_begin Heiner Kallweit
2021-08-05 11:51 ` Julian Wiedmann
2021-08-05 18:48 ` Heiner Kallweit
2021-08-01 16:25 ` [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops Heiner Kallweit
2021-08-02 14:15 ` Jakub Kicinski
2021-08-02 16:42 ` Heiner Kallweit
2021-08-02 16:54 ` Jakub Kicinski
2021-08-02 19:00 ` Heiner Kallweit
2021-08-03 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106547ef-7a61-2064-33f5-3cc8d12adb34@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).