Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Landen Chao <landen.chao@mediatek.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"vivien.didelot@savoirfairelinux.com" 
	<vivien.didelot@savoirfairelinux.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Sean Wang <Sean.Wang@mediatek.com>,
	"opensource@vdorst.com" <opensource@vdorst.com>,
	"frank-w@public-files.de" <frank-w@public-files.de>,
	"dqfext@gmail.com" <dqfext@gmail.com>
Subject: Re: [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board
Date: Wed, 19 Aug 2020 16:15:01 +0800	[thread overview]
Message-ID: <1597824901.31846.42.camel@mtksdccf07> (raw)
In-Reply-To: <20200818162433.elqh3dxmk6vilq6u@skbuf>

On Wed, 2020-08-19 at 00:24 +0800, Vladimir Oltean wrote:
> On Tue, Aug 18, 2020 at 03:14:12PM +0800, Landen Chao wrote:
> > Add mt7531 dsa to bananapi-bpi-r64 board for 5 giga Ethernet ports support.
> > 
> > Signed-off-by: Landen Chao <landen.chao@mediatek.com>
> > ---
> >  .../dts/mediatek/mt7622-bananapi-bpi-r64.dts  | 44 +++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> > index d174ad214857..c57b2571165f 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> > @@ -143,6 +143,50 @@
> >  	mdio: mdio-bus {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> > +
> > +		switch@0 {
> > +			compatible = "mediatek,mt7531";
> > +
[snip]
> > +				port@6 {
> > +					reg = <6>;
> > +					label = "cpu";
> > +					ethernet = <&gmac0>;
> > +					phy-mode = "2500base-x";
> > +				};
> 
> Is there any reason why you're not specifying a fixed-link node here?
I got the below feedback in v1, so I follow the DSA common design in v2.
v2 can work with fixed-link node or without fixed-link node in CPU port
node.

  "This fixed-link should not be needed. The DSA driver is supposed to
   configure the CPU port to its fastest speed by default. 2500 is
   the fastest speed a 2500Base-X link can do..."
> > +			};
> > +		};
> > +
> >  	};
> >  };
> >  
> > -- 
> > 2.17.1
> 
> Thanks,
> -Vladimir


  reply	other threads:[~2020-08-19  8:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18  7:14 [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Landen Chao
2020-08-18  7:14 ` [PATCH net-next v2 1/7] net: dsa: mt7530: Refine message in Kconfig Landen Chao
2020-08-18  7:14 ` [PATCH net-next v2 2/7] net: dsa: mt7530: support full-duplex gigabit only Landen Chao
2020-08-18 15:49   ` Andrew Lunn
2020-08-18  7:14 ` [PATCH net-next v2 3/7] net: dsa: mt7530: Extend device data ready for adding a new hardware Landen Chao
2020-08-18 15:56   ` Andrew Lunn
2020-08-18 17:31   ` Frank Wunderlich
2020-08-18  7:14 ` [PATCH net-next v2 4/7] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 Landen Chao
2020-08-25 19:43   ` Rob Herring
2020-08-18  7:14 ` [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch Landen Chao
2020-08-18 15:23   ` Jakub Kicinski
2020-08-19  9:50     ` Landen Chao
2020-08-18 16:09   ` Andrew Lunn
2020-08-19  9:44     ` Landen Chao
2020-08-19 13:12       ` Andrew Lunn
2020-08-19 23:46       ` René van Dorst
2020-08-20 15:29         ` Chuanhong Guo
2020-08-18  7:14 ` [PATCH net-next v2 6/7] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Landen Chao
2020-08-18 16:10   ` Andrew Lunn
2020-08-18  7:14 ` [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Landen Chao
2020-08-18 16:24   ` Vladimir Oltean
2020-08-19  8:15     ` Landen Chao [this message]
2020-08-19  8:51       ` Vladimir Oltean
2020-08-18 17:54 ` Aw: [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Frank Wunderlich
2020-08-19  3:49 ` DENG Qingfang
2020-08-19  7:38   ` Landen Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597824901.31846.42.camel@mtksdccf07 \
    --to=landen.chao@mediatek.com \
    --cc=Sean.Wang@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dqfext@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=frank-w@public-files.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=opensource@vdorst.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    --subject='Re: [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).