[PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()

[PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()

[Yang Li]

When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0.
So, we use -ENOMEM to indicate that the function
create_singlethread_workqueue() return NULL.

Clean up smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
mlx5e_arfs_create_tables() warn: missing error code 'err'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev when needed")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---

Changes in v2:
--According to Saeed's suggestion, we modify the format of Fixes tag, 
--and initialize err to -ENOMEM.
https://lore.kernel.org/patchwork/patch/1440018/

 drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
index 5cd466e..25403af 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
@@ -356,7 +356,7 @@ static int arfs_create_table(struct mlx5e_priv *priv,
 
 int mlx5e_arfs_create_tables(struct mlx5e_priv *priv)
 {
-	int err = 0;
+	int err = -ENOMEM;
 	int i;
 
 	if (!(priv->netdev->hw_features & NETIF_F_NTUPLE))
-- 
1.8.3.1

Re: [PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()

[Saeed Mahameed]

On Fri, 2021-06-04 at 18:08 +0800, Yang Li wrote:
> When the code execute 'if (!priv->fs.arfs->wq)', the value of err is
> 0.
> So, we use -ENOMEM to indicate that the function
> create_singlethread_workqueue() return NULL.
> 
> Clean up smatch warning:
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
> mlx5e_arfs_create_tables() warn: missing error code 'err'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev
> when needed")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> 
> Changes in v2:
> --According to Saeed's suggestion, we modify the format of Fixes tag,
> --and initialize err to -ENOMEM.
> https://lore.kernel.org/patchwork/patch/1440018/
> 

applied to net-mlx5.

thanks !