Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
@ 2021-07-15  6:00 Cong Wang
  2021-07-15 11:26 ` Yunsheng Lin
  2021-07-15 18:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Cong Wang @ 2021-07-15  6:00 UTC (permalink / raw)
  To: netdev; +Cc: Qitao Xu, Cong Wang

From: Qitao Xu <qitao.xu@bytedance.com>

Print format of skbaddr is changed to %px from %p, because we want
to use skb address as a quick way to identify a packet.

Note, trace ring buffer is only accessible to privileged users,
it is safe to use a real kernel address here.

Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: Qitao Xu <qitao.xu@bytedance.com>
---
 include/trace/events/qdisc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h
index 330d32d84485..58209557cb3a 100644
--- a/include/trace/events/qdisc.h
+++ b/include/trace/events/qdisc.h
@@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue,
 		__entry->txq_state	= txq->state;
 	),
 
-	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p",
+	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px",
 		  __entry->ifindex, __entry->handle, __entry->parent,
 		  __entry->txq_state, __entry->packets, __entry->skbaddr )
 );
-- 
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
  2021-07-15  6:00 [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue() Cong Wang
@ 2021-07-15 11:26 ` Yunsheng Lin
  2021-07-15 15:17   ` Cong Wang
  2021-07-15 18:10 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Yunsheng Lin @ 2021-07-15 11:26 UTC (permalink / raw)
  To: Cong Wang, netdev; +Cc: Qitao Xu, Cong Wang

On 2021/7/15 14:00, Cong Wang wrote:
> From: Qitao Xu <qitao.xu@bytedance.com>
> 
> Print format of skbaddr is changed to %px from %p, because we want
> to use skb address as a quick way to identify a packet.
> 
> Note, trace ring buffer is only accessible to privileged users,
> it is safe to use a real kernel address here.

Does it make more sense to use %pK?

see: https://lwn.net/Articles/420403/

> 
> Reviewed-by: Cong Wang <cong.wang@bytedance.com>
> Signed-off-by: Qitao Xu <qitao.xu@bytedance.com>
> ---
>  include/trace/events/qdisc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h
> index 330d32d84485..58209557cb3a 100644
> --- a/include/trace/events/qdisc.h
> +++ b/include/trace/events/qdisc.h
> @@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue,
>  		__entry->txq_state	= txq->state;
>  	),
>  
> -	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p",
> +	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px",
>  		  __entry->ifindex, __entry->handle, __entry->parent,
>  		  __entry->txq_state, __entry->packets, __entry->skbaddr )
>  );
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
  2021-07-15 11:26 ` Yunsheng Lin
@ 2021-07-15 15:17   ` Cong Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Cong Wang @ 2021-07-15 15:17 UTC (permalink / raw)
  To: Yunsheng Lin; +Cc: Linux Kernel Network Developers, Qitao Xu, Cong Wang

On Thu, Jul 15, 2021 at 4:26 AM Yunsheng Lin <linyunsheng@huawei.com> wrote:
>
> On 2021/7/15 14:00, Cong Wang wrote:
> > From: Qitao Xu <qitao.xu@bytedance.com>
> >
> > Print format of skbaddr is changed to %px from %p, because we want
> > to use skb address as a quick way to identify a packet.
> >
> > Note, trace ring buffer is only accessible to privileged users,
> > it is safe to use a real kernel address here.
>
> Does it make more sense to use %pK?
>
> see: https://lwn.net/Articles/420403/

I think you have the answer:

+ * %pK cannot be used in IRQ context because it tests
+ * CAP_SYSLOG.

;) So, no.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
  2021-07-15  6:00 [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue() Cong Wang
  2021-07-15 11:26 ` Yunsheng Lin
@ 2021-07-15 18:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-15 18:10 UTC (permalink / raw)
  To: Cong Wang; +Cc: netdev, qitao.xu, cong.wang

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 14 Jul 2021 23:00:21 -0700 you wrote:
> From: Qitao Xu <qitao.xu@bytedance.com>
> 
> Print format of skbaddr is changed to %px from %p, because we want
> to use skb address as a quick way to identify a packet.
> 
> Note, trace ring buffer is only accessible to privileged users,
> it is safe to use a real kernel address here.
> 
> [...]

Here is the summary with links:
  - [net-next,resend,v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
    https://git.kernel.org/netdev/net/c/851f36e40962

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-15 18:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15  6:00 [Patch net-next resend v2] net_sched: use %px to print skb address in trace_qdisc_dequeue() Cong Wang
2021-07-15 11:26 ` Yunsheng Lin
2021-07-15 15:17   ` Cong Wang
2021-07-15 18:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).