Netdev Archive on
help / color / mirror / Atom feed
To: Ilias Apalodimas <>
Subject: Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool packets
Date: Fri, 16 Jul 2021 18:50:04 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 16 Jul 2021 10:02:18 +0300 you wrote:
> As Alexander points out, when we are trying to recycle a cloned/expanded
> SKB we might trigger a race.  The recycling code relies on the
> pp_recycle bit to trigger,  which we carry over to cloned SKBs.
> If that cloned SKB gets expanded or if we get references to the frags,
> call skb_release_data() and overwrite skb->head, we are creating separate
> instances accessing the same page frags.  Since the skb_release_data()
> will first try to recycle the frags,  there's a potential race between
> the original and cloned SKB, since both will have the pp_recycle bit set.
> [...]

Here is the summary with links:
  - [1/1,v3] skbuff: Fix a potential race while recycling page_pool packets

You are awesome, thank you!
Deet-doot-dot, I am a bot.

      reply	other threads:[~2021-07-16 18:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  7:02 Ilias Apalodimas
2021-07-16 18:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool packets' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).