Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: sched: fix memory leak in tcindex_partial_destroy_work
@ 2021-07-17 11:29 Pavel Skripkin
  2021-07-18 16:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Skripkin @ 2021-07-17 11:29 UTC (permalink / raw)
  To: jhs, xiyou.wangcong, jiri, davem
  Cc: netdev, linux-kernel, Pavel Skripkin, syzbot+f0bbb2287b8993d4fa74

Syzbot reported memory leak in tcindex_set_parms(). The problem was in
non-freed perfect hash in tcindex_partial_destroy_work().

In tcindex_set_parms() new tcindex_data is allocated and some fields from
old one are copied to new one, but not the perfect hash. Since
tcindex_partial_destroy_work() is the destroy function for old
tcindex_data, we need to free perfect hash to avoid memory leak.

Reported-and-tested-by: syzbot+f0bbb2287b8993d4fa74@syzkaller.appspotmail.com
Fixes: 331b72922c5f ("net: sched: RCU cls_tcindex")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
 net/sched/cls_tcindex.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
index c4007b9cd16d..7ffc7be1e05d 100644
--- a/net/sched/cls_tcindex.c
+++ b/net/sched/cls_tcindex.c
@@ -278,6 +278,8 @@ static int tcindex_filter_result_init(struct tcindex_filter_result *r,
 			     TCA_TCINDEX_POLICE);
 }
 
+static void tcindex_free_perfect_hash(struct tcindex_data *cp);
+
 static void tcindex_partial_destroy_work(struct work_struct *work)
 {
 	struct tcindex_data *p = container_of(to_rcu_work(work),
@@ -285,7 +287,8 @@ static void tcindex_partial_destroy_work(struct work_struct *work)
 					      rwork);
 
 	rtnl_lock();
-	kfree(p->perfect);
+	if (p->perfect)
+		tcindex_free_perfect_hash(p);
 	kfree(p);
 	rtnl_unlock();
 }
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: sched: fix memory leak in tcindex_partial_destroy_work
  2021-07-17 11:29 [PATCH] net: sched: fix memory leak in tcindex_partial_destroy_work Pavel Skripkin
@ 2021-07-18 16:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-18 16:50 UTC (permalink / raw)
  To: Pavel Skripkin
  Cc: jhs, xiyou.wangcong, jiri, davem, netdev, linux-kernel,
	syzbot+f0bbb2287b8993d4fa74

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 17 Jul 2021 14:29:33 +0300 you wrote:
> Syzbot reported memory leak in tcindex_set_parms(). The problem was in
> non-freed perfect hash in tcindex_partial_destroy_work().
> 
> In tcindex_set_parms() new tcindex_data is allocated and some fields from
> old one are copied to new one, but not the perfect hash. Since
> tcindex_partial_destroy_work() is the destroy function for old
> tcindex_data, we need to free perfect hash to avoid memory leak.
> 
> [...]

Here is the summary with links:
  - net: sched: fix memory leak in tcindex_partial_destroy_work
    https://git.kernel.org/netdev/net/c/f5051bcece50

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-18 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-17 11:29 [PATCH] net: sched: fix memory leak in tcindex_partial_destroy_work Pavel Skripkin
2021-07-18 16:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).