Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol()
@ 2021-07-17 12:32 Marek Vasut
  2021-07-17 16:09 ` Florian Fainelli
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2021-07-17 12:32 UTC (permalink / raw)
  To: netdev; +Cc: Marek Vasut, Andrew Lunn, Florian Fainelli, David S . Miller

The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not
int, just inline the value into the function call arguments.

No functional change.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
---
 drivers/net/phy/dp83822.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index f7a2ec150e54..211b5476a6f5 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -326,11 +326,9 @@ static irqreturn_t dp83822_handle_interrupt(struct phy_device *phydev)
 
 static int dp8382x_disable_wol(struct phy_device *phydev)
 {
-	int value = DP83822_WOL_EN | DP83822_WOL_MAGIC_EN |
-		    DP83822_WOL_SECURE_ON;
-
-	return phy_clear_bits_mmd(phydev, DP83822_DEVADDR,
-				  MII_DP83822_WOL_CFG, value);
+	return phy_clear_bits_mmd(phydev, DP83822_DEVADDR, MII_DP83822_WOL_CFG,
+				  DP83822_WOL_EN | DP83822_WOL_MAGIC_EN |
+				  DP83822_WOL_SECURE_ON);
 }
 
 static int dp83822_read_status(struct phy_device *phydev)
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol()
  2021-07-17 12:32 [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol() Marek Vasut
@ 2021-07-17 16:09 ` Florian Fainelli
  2021-07-17 16:48 ` Andrew Lunn
  2021-07-18 16:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-07-17 16:09 UTC (permalink / raw)
  To: Marek Vasut, netdev; +Cc: Andrew Lunn, David S . Miller



On 7/17/2021 5:32 AM, Marek Vasut wrote:
> The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not
> int, just inline the value into the function call arguments.
> 
> No functional change.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol()
  2021-07-17 12:32 [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol() Marek Vasut
  2021-07-17 16:09 ` Florian Fainelli
@ 2021-07-17 16:48 ` Andrew Lunn
  2021-07-18 16:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2021-07-17 16:48 UTC (permalink / raw)
  To: Marek Vasut; +Cc: netdev, Florian Fainelli, David S . Miller

On Sat, Jul 17, 2021 at 02:32:49PM +0200, Marek Vasut wrote:
> The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not
> int, just inline the value into the function call arguments.
> 
> No functional change.

I don't think there is an overflow issue here, so this can go into
net-next. The subject should reflect this, Subject: [PATCH net-next] ...

Thanks for splitting it into a standalone patch.

> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol()
  2021-07-17 12:32 [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol() Marek Vasut
  2021-07-17 16:09 ` Florian Fainelli
  2021-07-17 16:48 ` Andrew Lunn
@ 2021-07-18 16:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-18 16:50 UTC (permalink / raw)
  To: Marek Vasut; +Cc: netdev, andrew, f.fainelli, davem

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 17 Jul 2021 14:32:49 +0200 you wrote:
> The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not
> int, just inline the value into the function call arguments.
> 
> No functional change.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> 
> [...]

Here is the summary with links:
  - net: phy: Fix data type in DP83822 dp8382x_disable_wol()
    https://git.kernel.org/netdev/net-next/c/0d6835ffe50c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-18 16:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-17 12:32 [PATCH] net: phy: Fix data type in DP83822 dp8382x_disable_wol() Marek Vasut
2021-07-17 16:09 ` Florian Fainelli
2021-07-17 16:48 ` Andrew Lunn
2021-07-18 16:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).