Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] net: phy: at803x: finish the phy id checking simplification
@ 2021-07-20 17:24 Vladimir Oltean
  2021-07-20 17:36 ` Russell King (Oracle)
  2021-07-21 15:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Oltean @ 2021-07-20 17:24 UTC (permalink / raw)
  To: netdev, Jakub Kicinski, David S. Miller
  Cc: Andrew Lunn, Heiner Kallweit, Russell King, Fabio Estevam

The blamed commit was probably not tested on net-next, since it did not
refactor the extra phy id check introduced in commit b856150c8098 ("net:
phy: at803x: mask 1000 Base-X link mode").

Fixes: 8887ca5474bd ("net: phy: at803x: simplify custom phy id matching")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/phy/at803x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 0790ffcd3db6..bdac087058b2 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -703,7 +703,7 @@ static int at803x_get_features(struct phy_device *phydev)
 	if (err)
 		return err;
 
-	if (!at803x_match_phy_id(phydev, ATH8031_PHY_ID))
+	if (phydev->drv->phy_id != ATH8031_PHY_ID)
 		return 0;
 
 	/* AR8031/AR8033 have different status registers
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phy: at803x: finish the phy id checking simplification
  2021-07-20 17:24 [PATCH net-next] net: phy: at803x: finish the phy id checking simplification Vladimir Oltean
@ 2021-07-20 17:36 ` Russell King (Oracle)
  2021-07-21 15:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2021-07-20 17:36 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: netdev, Jakub Kicinski, David S. Miller, Andrew Lunn,
	Heiner Kallweit, Fabio Estevam

On Tue, Jul 20, 2021 at 08:24:33PM +0300, Vladimir Oltean wrote:
> The blamed commit was probably not tested on net-next, since it did not
> refactor the extra phy id check introduced in commit b856150c8098 ("net:
> phy: at803x: mask 1000 Base-X link mode").
> 
> Fixes: 8887ca5474bd ("net: phy: at803x: simplify custom phy id matching")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Thanks for catching this and sorry for the breakage - the humidity in
the UK is getting to me (particularly causing tiredness), so I've
obviously missed stuff. :(

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phy: at803x: finish the phy id checking simplification
  2021-07-20 17:24 [PATCH net-next] net: phy: at803x: finish the phy id checking simplification Vladimir Oltean
  2021-07-20 17:36 ` Russell King (Oracle)
@ 2021-07-21 15:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-21 15:00 UTC (permalink / raw)
  To: Vladimir Oltean; +Cc: netdev, kuba, davem, andrew, hkallweit1, linux, festevam

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 20 Jul 2021 20:24:33 +0300 you wrote:
> The blamed commit was probably not tested on net-next, since it did not
> refactor the extra phy id check introduced in commit b856150c8098 ("net:
> phy: at803x: mask 1000 Base-X link mode").
> 
> Fixes: 8887ca5474bd ("net: phy: at803x: simplify custom phy id matching")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: at803x: finish the phy id checking simplification
    https://git.kernel.org/netdev/net-next/c/f5621a01c86b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-21 15:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 17:24 [PATCH net-next] net: phy: at803x: finish the phy id checking simplification Vladimir Oltean
2021-07-20 17:36 ` Russell King (Oracle)
2021-07-21 15:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).