Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next v1 1/1] net: usb: asix: ax88772: do not poll for PHY before registering it
@ 2021-07-22  7:23 Oleksij Rempel
  2021-07-22  8:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2021-07-22  7:23 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Andrew Lunn, Heiner Kallweit,
	Russell King
  Cc: Oleksij Rempel, kernel, linux-kernel, linux-usb, netdev

asix_get_phyid() is used for two reasons here. To print debug message
with the PHY ID and to wait until the PHY is powered up.

After migrating to the phylib, we can read PHYID from sysfs. If polling
for the PHY is really needed, then we will need to handle it in the
phylib as well.

This change was tested with:
- ax88772a + internal PHY
- ax88772b + external PHY

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/usb/asix_devices.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 2c115216420a..049c20342a0b 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -714,7 +714,6 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 	u8 buf[ETH_ALEN] = {0}, chipcode = 0;
 	struct asix_common_private *priv;
 	int ret, i;
-	u32 phyid;
 
 	usbnet_get_endpoints(dev, intf);
 
@@ -762,10 +761,6 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 		return ret;
 	}
 
-	/* Read PHYID register *AFTER* the PHY was reset properly */
-	phyid = asix_get_phyid(dev);
-	netdev_dbg(dev->net, "PHYID=0x%08x\n", phyid);
-
 	/* Asix framing packs multiple eth frames into a 2K usb bulk transfer */
 	if (dev->driver_info->flags & FLAG_FRAMING_AX) {
 		/* hard_mtu  is still the default - the device does not support
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next v1 1/1] net: usb: asix: ax88772: do not poll for PHY before registering it
  2021-07-22  7:23 [PATCH net-next v1 1/1] net: usb: asix: ax88772: do not poll for PHY before registering it Oleksij Rempel
@ 2021-07-22  8:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-22  8:00 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: davem, kuba, andrew, hkallweit1, linux, kernel, linux-kernel,
	linux-usb, netdev

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 22 Jul 2021 09:23:38 +0200 you wrote:
> asix_get_phyid() is used for two reasons here. To print debug message
> with the PHY ID and to wait until the PHY is powered up.
> 
> After migrating to the phylib, we can read PHYID from sysfs. If polling
> for the PHY is really needed, then we will need to handle it in the
> phylib as well.
> 
> [...]

Here is the summary with links:
  - [net-next,v1,1/1] net: usb: asix: ax88772: do not poll for PHY before registering it
    https://git.kernel.org/netdev/net-next/c/fdc362bff913

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-22  8:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22  7:23 [PATCH net-next v1 1/1] net: usb: asix: ax88772: do not poll for PHY before registering it Oleksij Rempel
2021-07-22  8:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).