Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [net PATCH] octeontx2-af: Remove unnecessary devm_kfree
@ 2021-07-22 12:45 Sunil Goutham
  2021-07-23 15:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Sunil Goutham @ 2021-07-22 12:45 UTC (permalink / raw)
  To: netdev, davem, kuba; +Cc: Sunil Goutham

Remove devm_kfree of memory where VLAN entry to RVU PF mapping
info is saved. This will be freed anyway at driver exit.
Having this could result in warning from devm_kfree() if
the memory is not allocated due to errors in rvu_nix_block_init()
before nix_setup_txvlan().

Fixes: 9a946def264d ("octeontx2-af: Modify nix_vtag_cfg mailbox to support TX VTAG entries")
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
index 0933699..0d2cd51 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
@@ -3842,7 +3842,6 @@ static void rvu_nix_block_freemem(struct rvu *rvu, int blkaddr,
 		vlan = &nix_hw->txvlan;
 		kfree(vlan->rsrc.bmap);
 		mutex_destroy(&vlan->rsrc_lock);
-		devm_kfree(rvu->dev, vlan->entry2pfvf_map);
 
 		mcast = &nix_hw->mcast;
 		qmem_free(rvu->dev, mcast->mce_ctx);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [net PATCH] octeontx2-af: Remove unnecessary devm_kfree
  2021-07-22 12:45 [net PATCH] octeontx2-af: Remove unnecessary devm_kfree Sunil Goutham
@ 2021-07-23 15:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-23 15:10 UTC (permalink / raw)
  To: Sunil Goutham; +Cc: netdev, davem, kuba

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 22 Jul 2021 18:15:51 +0530 you wrote:
> Remove devm_kfree of memory where VLAN entry to RVU PF mapping
> info is saved. This will be freed anyway at driver exit.
> Having this could result in warning from devm_kfree() if
> the memory is not allocated due to errors in rvu_nix_block_init()
> before nix_setup_txvlan().
> 
> Fixes: 9a946def264d ("octeontx2-af: Modify nix_vtag_cfg mailbox to support TX VTAG entries")
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> 
> [...]

Here is the summary with links:
  - [net] octeontx2-af: Remove unnecessary devm_kfree
    https://git.kernel.org/netdev/net/c/d72e91efcae1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-23 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 12:45 [net PATCH] octeontx2-af: Remove unnecessary devm_kfree Sunil Goutham
2021-07-23 15:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).