Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY
@ 2021-07-23 13:59 Kevin Lo
  2021-07-23 16:09 ` Florian Fainelli
  2021-07-25  9:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Kevin Lo @ 2021-07-23 13:59 UTC (permalink / raw)
  To: Florian Fainelli; +Cc: David S. Miller, netdev

Restore PHY_ID_BCM54811 accidently removed by commit 5d4358ede8eb.

Fixes: 5d4358ede8eb ("net: phy: broadcom: Allow BCM54210E to configure APD")
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 7bf3011b8e77..83aea5c5cd03 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -288,7 +288,7 @@ static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
 	if (phydev->dev_flags & PHY_BRCM_DIS_TXCRXC_NOENRGY) {
 		if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E ||
 		    BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54810 ||
-		    BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E)
+		    BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54811)
 			val |= BCM54XX_SHD_SCR3_RXCTXC_DIS;
 		else
 			val |= BCM54XX_SHD_SCR3_TRDDAPD;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY
  2021-07-23 13:59 [PATCH] net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY Kevin Lo
@ 2021-07-23 16:09 ` Florian Fainelli
  2021-07-25  9:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-07-23 16:09 UTC (permalink / raw)
  To: Kevin Lo; +Cc: David S. Miller, netdev



On 7/23/2021 6:59 AM, Kevin Lo wrote:
> Restore PHY_ID_BCM54811 accidently removed by commit 5d4358ede8eb.
> 
> Fixes: 5d4358ede8eb ("net: phy: broadcom: Allow BCM54210E to configure APD")
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Sorry about that, this was due to me incorrectly merging the changes 
when they were forward ported, good catch!
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY
  2021-07-23 13:59 [PATCH] net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY Kevin Lo
  2021-07-23 16:09 ` Florian Fainelli
@ 2021-07-25  9:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-25  9:50 UTC (permalink / raw)
  To: Kevin Lo; +Cc: f.fainelli, davem, netdev

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 23 Jul 2021 21:59:27 +0800 you wrote:
> Restore PHY_ID_BCM54811 accidently removed by commit 5d4358ede8eb.
> 
> Fixes: 5d4358ede8eb ("net: phy: broadcom: Allow BCM54210E to configure APD")
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> ---

Here is the summary with links:
  - net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY
    https://git.kernel.org/netdev/net/c/ad4e1e48a629

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-25  9:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 13:59 [PATCH] net: phy: broadcom: re-add check for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54811 PHY Kevin Lo
2021-07-23 16:09 ` Florian Fainelli
2021-07-25  9:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).