Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument
@ 2021-07-27  4:10 Juhee Kang
  2021-07-27  4:10 ` [bpf-next v2 2/2] samples: bpf: Add the omitted xdp samples to .gitignore Juhee Kang
  2021-07-27 18:20 ` [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Juhee Kang @ 2021-07-27  4:10 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, Yonghong Song
  Cc: netdev, bpf

The current behavior of 'tracex7' doesn't consist with other bpf samples
tracex{1..6}. Other samples do not require any argument to run with, but
tracex7 should be run with btrfs device argument. (it should be executed
with test_override_return.sh)

Currently, tracex7 doesn't have any description about how to run this
program and raises an unexpected error. And this result might be
confusing since users might not have a hunch about how to run this
program.

    // Current behavior
    # ./tracex7
    sh: 1: Syntax error: word unexpected (expecting ")")
    // Fixed behavior
    # ./tracex7
    ERROR: Run with the btrfs device argument!

In order to fix this error, this commit adds logic to report a message
and exit when running this program with a missing argument.

Additionally in test_override_return.sh, there is a problem with
multiple directory(tmpmnt) creation. So in this commit adds a line with
removing the directory with every execution.

Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Acked-by: Yonghong Song <yhs@fb.com>
---
Change in v2:
 - change directory remove option from -rf to -r

 samples/bpf/test_override_return.sh | 1 +
 samples/bpf/tracex7_user.c          | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/samples/bpf/test_override_return.sh b/samples/bpf/test_override_return.sh
index e68b9ee6814b..35db26f736b9 100755
--- a/samples/bpf/test_override_return.sh
+++ b/samples/bpf/test_override_return.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+rm -r tmpmnt
 rm -f testfile.img
 dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1
 DEVICE=$(losetup --show -f testfile.img)
diff --git a/samples/bpf/tracex7_user.c b/samples/bpf/tracex7_user.c
index fdcd6580dd73..8be7ce18d3ba 100644
--- a/samples/bpf/tracex7_user.c
+++ b/samples/bpf/tracex7_user.c
@@ -14,6 +14,11 @@ int main(int argc, char **argv)
 	int ret = 0;
 	FILE *f;
 
+	if (!argv[1]) {
+		fprintf(stderr, "ERROR: Run with the btrfs device argument!\n");
+		return 0;
+	}
+
 	snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]);
 	obj = bpf_object__open_file(filename, NULL);
 	if (libbpf_get_error(obj)) {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bpf-next v2 2/2] samples: bpf: Add the omitted xdp samples to .gitignore
  2021-07-27  4:10 [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Juhee Kang
@ 2021-07-27  4:10 ` Juhee Kang
  2021-07-27 18:20 ` [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Juhee Kang @ 2021-07-27  4:10 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, Yonghong Song
  Cc: netdev, bpf

There are recently added xdp samples (xdp_redirect_map_multi and
xdpsock_ctrl_proc) which are not managed by .gitignore.

This commit adds these files to .gitignore.

Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
---
 samples/bpf/.gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
index 0b9548ea8477..fcba217f0ae2 100644
--- a/samples/bpf/.gitignore
+++ b/samples/bpf/.gitignore
@@ -45,11 +45,13 @@ xdp_monitor
 xdp_redirect
 xdp_redirect_cpu
 xdp_redirect_map
+xdp_redirect_map_multi
 xdp_router_ipv4
 xdp_rxq_info
 xdp_sample_pkts
 xdp_tx_iptunnel
 xdpsock
+xdpsock_ctrl_proc
 xsk_fwd
 testfile.img
 hbm_out.log
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument
  2021-07-27  4:10 [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Juhee Kang
  2021-07-27  4:10 ` [bpf-next v2 2/2] samples: bpf: Add the omitted xdp samples to .gitignore Juhee Kang
@ 2021-07-27 18:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-27 18:20 UTC (permalink / raw)
  To: Juhee Kang; +Cc: daniel, ast, andrii, yhs, netdev, bpf

Hello:

This series was applied to bpf/bpf-next.git (refs/heads/master):

On Tue, 27 Jul 2021 04:10:55 +0000 you wrote:
> The current behavior of 'tracex7' doesn't consist with other bpf samples
> tracex{1..6}. Other samples do not require any argument to run with, but
> tracex7 should be run with btrfs device argument. (it should be executed
> with test_override_return.sh)
> 
> Currently, tracex7 doesn't have any description about how to run this
> program and raises an unexpected error. And this result might be
> confusing since users might not have a hunch about how to run this
> program.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2,1/2] samples: bpf: Fix tracex7 error raised on the missing argument
    https://git.kernel.org/bpf/bpf-next/c/7d07006f0592
  - [bpf-next,v2,2/2] samples: bpf: Add the omitted xdp samples to .gitignore
    https://git.kernel.org/bpf/bpf-next/c/05e9b4f60d31

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-27 18:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  4:10 [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Juhee Kang
2021-07-27  4:10 ` [bpf-next v2 2/2] samples: bpf: Add the omitted xdp samples to .gitignore Juhee Kang
2021-07-27 18:20 ` [bpf-next v2 1/2] samples: bpf: Fix tracex7 error raised on the missing argument patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).