Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next 0/6] sk_buff: optimize GRO for the common case
@ 2021-07-28 16:23 Paolo Abeni
  2021-07-28 16:23 ` [PATCH net-next 1/6] sk_buff: introduce 'slow_gro' flags Paolo Abeni
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Paolo Abeni @ 2021-07-28 16:23 UTC (permalink / raw)
  To: netdev; +Cc: David S. Miller, Jakub Kicinski, Eric Dumazet

This is a trimmed down revision of "sk_buff: optimize layout for GRO",
specifically dropping the changes to the sk_buff layout[1].

This series tries to accomplish 2 goals:
- optimize the GRO stage for the most common scenario, avoiding a bunch
  of conditional and some more code
- let owned skbs entering the GRO engine, allowing backpressure in the
  veth GRO forward path.

A new sk_buff flag (!!!) is introduced and maintained for GRO's sake.
Such field uses an existing hole, so there is no change to the sk_buff
size.

[1] two main reasons:
- move skb->inner_ field requires some extra care, as some in kernel
  users access and the fields regardless of skb->encapsulation.
- extending secmark size clash with ct and nft uAPIs

address the all above is possible, I think, but for sure not in a single
series.

Paolo Abeni (6):
  sk_buff: introduce 'slow_gro' flags
  sk_buff: track dst status in slow_gro
  sk_buff: track extension status in slow_gro
  net: optimize GRO for the common case.
  skbuff: allow 'slow_gro' for skb carring sock reference
  veth: use skb_prepare_for_gro()

 drivers/net/veth.c     |  2 +-
 include/linux/skbuff.h |  6 ++++++
 include/net/dst.h      |  2 ++
 include/net/sock.h     |  9 +++++++++
 net/core/dev.c         | 32 ++++++++++++++++++++++++--------
 net/core/skbuff.c      | 27 ++++++++++++++++++++-------
 6 files changed, 62 insertions(+), 16 deletions(-)

-- 
2.26.3


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-07-30 13:08 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 16:23 [PATCH net-next 0/6] sk_buff: optimize GRO for the common case Paolo Abeni
2021-07-28 16:23 ` [PATCH net-next 1/6] sk_buff: introduce 'slow_gro' flags Paolo Abeni
2021-07-28 16:24 ` [PATCH net-next 2/6] sk_buff: track dst status in slow_gro Paolo Abeni
2021-07-30 11:08   ` Jakub Kicinski
2021-07-30 13:08     ` Paolo Abeni
2021-07-28 16:24 ` [PATCH net-next 3/6] sk_buff: track extension " Paolo Abeni
2021-07-28 16:24 ` [PATCH net-next 4/6] net: optimize GRO for the common case Paolo Abeni
2021-07-28 16:24 ` [PATCH net-next 5/6] skbuff: allow 'slow_gro' for skb carring sock reference Paolo Abeni
2021-07-28 16:24 ` [PATCH net-next 6/6] veth: use skb_prepare_for_gro() Paolo Abeni
2021-07-29 11:20 ` [PATCH net-next 0/6] sk_buff: optimize GRO for the common case patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox