Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ipvlan: Add handling of NETDEV_UP events
@ 2021-07-29 13:19 Di Zhu
  2021-07-29 21:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Di Zhu @ 2021-07-29 13:19 UTC (permalink / raw)
  To: davem, kuba, maheshb; +Cc: netdev, zhudi21, rose.chen

When an ipvlan device is created on a bond device, the link state
of the ipvlan device may be abnormal. This is because bonding device
allows to add physical network card device in the down state and so
NETDEV_CHANGE event will not be notified to other listeners, so ipvlan
has no chance to update its link status.

The following steps can cause such problems:
	1) bond0 is down
	2) ip link add link bond0 name ipvlan type ipvlan mode l2
	3) echo +enp2s7 >/sys/class/net/bond0/bonding/slaves
	4) ip link set bond0 up

After these steps, use ip link command, we found ipvlan has NO-CARRIER:
  ipvlan@bond0: <NO-CARRIER, BROADCAST,MULTICAST,UP,M-DOWN> mtu ...>

We can deal with this problem like VLAN: Add handling of NETDEV_UP
events. If we receive NETDEV_UP event, we will update the link status
of the ipvlan.

Signed-off-by: Di Zhu <zhudi21@huawei.com>
---
 drivers/net/ipvlan/ipvlan_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index a707502a0c0f..c0b21a5580d5 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -732,6 +732,7 @@ static int ipvlan_device_event(struct notifier_block *unused,
 	port = ipvlan_port_get_rtnl(dev);
 
 	switch (event) {
+	case NETDEV_UP:
 	case NETDEV_CHANGE:
 		list_for_each_entry(ipvlan, &port->ipvlans, pnode)
 			netif_stacked_transfer_operstate(ipvlan->phy_dev,
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipvlan: Add handling of NETDEV_UP events
  2021-07-29 13:19 [PATCH] ipvlan: Add handling of NETDEV_UP events Di Zhu
@ 2021-07-29 21:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-29 21:20 UTC (permalink / raw)
  To: Di Zhu; +Cc: davem, kuba, maheshb, netdev, rose.chen

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 29 Jul 2021 21:19:30 +0800 you wrote:
> When an ipvlan device is created on a bond device, the link state
> of the ipvlan device may be abnormal. This is because bonding device
> allows to add physical network card device in the down state and so
> NETDEV_CHANGE event will not be notified to other listeners, so ipvlan
> has no chance to update its link status.
> 
> The following steps can cause such problems:
> 	1) bond0 is down
> 	2) ip link add link bond0 name ipvlan type ipvlan mode l2
> 	3) echo +enp2s7 >/sys/class/net/bond0/bonding/slaves
> 	4) ip link set bond0 up
> 
> [...]

Here is the summary with links:
  - ipvlan: Add handling of NETDEV_UP events
    https://git.kernel.org/netdev/net-next/c/57fb346cc7d0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-29 21:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 13:19 [PATCH] ipvlan: Add handling of NETDEV_UP events Di Zhu
2021-07-29 21:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox