Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net] docs: networking: netdevsim rules
@ 2021-08-03 23:14 Jakub Kicinski
2021-08-04 11:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2021-08-03 23:14 UTC (permalink / raw)
To: davem; +Cc: corbet, linux-doc, xiyou.wangcong, netdev, Jakub Kicinski
There are aspects of netdevsim which are commonly
misunderstood and pointed out in review. Cong
suggest we document them.
Suggested-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Documentation/networking/netdev-FAQ.rst | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/networking/netdev-FAQ.rst b/Documentation/networking/netdev-FAQ.rst
index 91b2cf712801..e26532f49760 100644
--- a/Documentation/networking/netdev-FAQ.rst
+++ b/Documentation/networking/netdev-FAQ.rst
@@ -228,6 +228,23 @@ before posting to the mailing list. The patchwork build bot instance
gets overloaded very easily and netdev@vger really doesn't need more
traffic if we can help it.
+netdevsim is great, can I extend it for my out-of-tree tests?
+-------------------------------------------------------------
+
+No, `netdevsim` is a test vehicle solely for upstream tests.
+(Please add your tests under tools/testing/selftests/.)
+
+We also give no guarantees that `netdevsim` won't change in the future
+in a way which would break what would normally be considered uAPI.
+
+Is netdevsim considered a "user" of an API?
+-------------------------------------------
+
+Linux kernel has a long standing rule that no API should be added unless
+it has a real, in-tree user. Mock-ups and tests based on `netdevsim` are
+strongly encouraged when adding new APIs, but `netdevsim` in itself
+is **not** considered a use case/user.
+
Any other tips to help ensure my net/net-next patch gets OK'd?
--------------------------------------------------------------
Attention to detail. Re-read your own work as if you were the
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] docs: networking: netdevsim rules
2021-08-03 23:14 [PATCH net] docs: networking: netdevsim rules Jakub Kicinski
@ 2021-08-04 11:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-04 11:50 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, corbet, linux-doc, xiyou.wangcong, netdev
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 3 Aug 2021 16:14:15 -0700 you wrote:
> There are aspects of netdevsim which are commonly
> misunderstood and pointed out in review. Cong
> suggest we document them.
>
> Suggested-by: Cong Wang <xiyou.wangcong@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net] docs: networking: netdevsim rules
https://git.kernel.org/netdev/net/c/396492b4c5f2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-04 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 23:14 [PATCH net] docs: networking: netdevsim rules Jakub Kicinski
2021-08-04 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).